]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
wifi: mwifiex: Fix uninitialized variable in mwifiex_cfg80211_authenticate()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 15 Aug 2024 11:29:27 +0000 (14:29 +0300)
committerKalle Valo <kvalo@kernel.org>
Thu, 22 Aug 2024 08:41:37 +0000 (11:41 +0300)
Smatch complains that:

    drivers/net/wireless/marvell/mwifiex/cfg80211.c:4408 mwifiex_cfg80211_authenticate()
    error: uninitialized symbol 'varptr'.

It's a check for NULL, but "varptr" is either non-NULL or uninitialized.
Initialize it to NULL.

Fixes: 36995892c271 ("wifi: mwifiex: add host mlme for client mode")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/d7d043b2-95d5-4e1d-b340-5d7330053ac6@stanley.mountain
drivers/net/wireless/marvell/mwifiex/cfg80211.c

index e36ef075fe053a4db98272800ace3878aa3e738c..888b586da266097ee6694b4753f88fb234008041 100644 (file)
@@ -4284,7 +4284,7 @@ mwifiex_cfg80211_authenticate(struct wiphy *wiphy,
        struct mwifiex_txinfo *tx_info;
        u32 tx_control = 0, pkt_type = PKT_TYPE_MGMT;
        u8 trans = 1, status_code = 0;
-       u8 *varptr;
+       u8 *varptr = NULL;
 
        if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_UAP) {
                mwifiex_dbg(priv->adapter, ERROR, "Interface role is AP\n");