]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/mlx5e: Report rx_discards_phy via rx_dropped
authorYafang Shao <laoar.shao@gmail.com>
Tue, 10 Dec 2024 02:27:06 +0000 (10:27 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Dec 2024 23:18:25 +0000 (15:18 -0800)
We noticed a high number of rx_discards_phy events on certain servers while
running `ethtool -S`. However, this critical counter is not currently
included in the standard /proc/net/dev statistics file, making it difficult
to monitor effectively—especially given the diversity of vendors across a
large fleet of servers.

Let's report it via the standard rx_dropped metric.

Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Gal Pressman <gal@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20241210022706.6665-1-laoar.shao@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index dd16d73000c3120a7be70d95e2d0457e00d2c39f..15e765a41d7290b35823a18f02c923886f4a0f39 100644 (file)
@@ -3946,6 +3946,7 @@ mlx5e_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats)
        }
 
        stats->rx_missed_errors = priv->stats.qcnt.rx_out_of_buffer;
+       stats->rx_dropped = PPORT_2863_GET(pstats, if_in_discards);
 
        stats->rx_length_errors =
                PPORT_802_3_GET(pstats, a_in_range_length_errors) +