]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: ibm: emac: use devm_platform_ioremap_resource
authorRosen Penev <rosenp@gmail.com>
Tue, 22 Oct 2024 00:22:42 +0000 (17:22 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 29 Oct 2024 14:33:23 +0000 (15:33 +0100)
No need to have a struct resource. Gets rid of the TODO.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/ibm/emac/core.c

index 0edcb435e62f646a285c20c4bdf14f266437b084..f387c4635cc665ba2266aa2d5cf56edd120b6e88 100644 (file)
@@ -3050,12 +3050,10 @@ static int emac_probe(struct platform_device *ofdev)
 
        ndev->irq = dev->emac_irq;
 
-       /* Map EMAC regs */
-       // TODO : platform_get_resource() and devm_ioremap_resource()
-       dev->emacp = devm_of_iomap(&ofdev->dev, np, 0, NULL);
-       if (!dev->emacp) {
+       dev->emacp = devm_platform_ioremap_resource(ofdev, 0);
+       if (IS_ERR(dev->emacp)) {
                dev_err(&ofdev->dev, "can't map device registers");
-               err = -ENOMEM;
+               err = PTR_ERR(dev->emacp);
                goto err_gone;
        }