]> www.infradead.org Git - users/hch/configfs.git/commitdiff
drm/amdgpu: Validate TA binary size
authorCandice Li <candice.li@amd.com>
Thu, 15 Aug 2024 03:37:28 +0000 (11:37 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Aug 2024 03:04:17 +0000 (23:04 -0400)
Add TA binary size validation to avoid OOB write.

Signed-off-by: Candice Li <candice.li@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit c0a04e3570d72aaf090962156ad085e37c62e442)
Cc: stable@vger.kernel.org
drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c

index 0c856005df6b95642af7b7ae4bdbf6a33a86f7ee..38face981c3e38779f4f93db6a0cdf739e6d60a8 100644 (file)
@@ -166,6 +166,9 @@ static ssize_t ta_if_load_debugfs_write(struct file *fp, const char *buf, size_t
        if (ret)
                return -EFAULT;
 
+       if (ta_bin_len > PSP_1_MEG)
+               return -EINVAL;
+
        copy_pos += sizeof(uint32_t);
 
        ta_bin = kzalloc(ta_bin_len, GFP_KERNEL);