fbdev: Make drivers depend on LCD_CLASS_DEVICE

LCD_CLASS_DEVICE is the user-controlled option that enables the LCD
display subsystem. Do not select it from fbdev drivers. Selecting it
from drivers can lead to cyclic dependencies within the config.

Some guidelines for using select can be found in the kernel docs at [1].

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147
Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index ed1ecc0ded5cea6b156e6c3e2479e80f81105ac9..19556d7629e0892ce559fab1412bd6611f4cc14b 100644 (file)
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -126,9 +126,9 @@ config FB_ACORN
 config FB_CLPS711X
        tristate "CLPS711X LCD support"
        depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
+       depends on LCD_CLASS_DEVICE
        select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
-       select LCD_CLASS_DEVICE
        select VIDEOMODE_HELPERS
        help
          Say Y to enable the Framebuffer driver for the Cirrus Logic
@@ -150,7 +150,7 @@ config FB_IMX
        tristate "Freescale i.MX1/21/25/27 LCD support"
        depends on FB && HAVE_CLK && HAS_IOMEM
        depends on ARCH_MXC || COMPILE_TEST
-       select LCD_CLASS_DEVICE
+       depends on LCD_CLASS_DEVICE
        select FB_IOMEM_HELPERS
        select FB_MODE_HELPERS
        select VIDEOMODE_HELPERS