]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
phy: phy-rockchip-samsung-hdptx: annotate regmap register-callback
authorHeiko Stuebner <heiko.stuebner@cherry.de>
Fri, 6 Dec 2024 10:34:00 +0000 (11:34 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 10 Feb 2025 16:58:50 +0000 (22:28 +0530)
The variant of the driver in the vendor-tree contained those handy
comments in the regmap register callback. Having the different ranges
describe what they are looks helpful.

Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Link: https://lore.kernel.org/r/20241206103401.1780416-2-heiko@sntech.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

index 0965b9d4f9cf1926ba2aaa54c3d1b105ecd1a5a2..f3bac8db2d88651345eae9e1b2f6daeb86d395b1 100644 (file)
@@ -560,13 +560,13 @@ static const struct reg_sequence rk_hdtpx_tmds_lane_init_seq[] = {
 static bool rk_hdptx_phy_is_rw_reg(struct device *dev, unsigned int reg)
 {
        switch (reg) {
-       case 0x0000 ... 0x029c:
-       case 0x0400 ... 0x04a4:
-       case 0x0800 ... 0x08a4:
-       case 0x0c00 ... 0x0cb4:
-       case 0x1000 ... 0x10b4:
-       case 0x1400 ... 0x14b4:
-       case 0x1800 ... 0x18b4:
+       case 0x0000 ... 0x029c: /* CMN Register */
+       case 0x0400 ... 0x04a4: /* Sideband Register */
+       case 0x0800 ... 0x08a4: /* Lane Top Register */
+       case 0x0c00 ... 0x0cb4: /* Lane 0 Register */
+       case 0x1000 ... 0x10b4: /* Lane 1 Register */
+       case 0x1400 ... 0x14b4: /* Lane 2 Register */
+       case 0x1800 ... 0x18b4: /* Lane 3 Register */
                return true;
        }