Address static analysis warning

esp.c:451:3: warning: The 1st argument to 'close' is <= -2 but should be >= -1 [unix.StdCLibraryFunctions]
  451 |                 closesocket(vpninfo->dtls_fd);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./openconnect-internal.h:1176:21: note: expanded from macro 'closesocket'
 1176 | #define closesocket close
      |                     ^

Signed-off-by: Dimitri Papadopoulos Orfanos <3350651-DimitriPapadopoulos@users.noreply.gitlab.com>

diff --git a/esp.c b/esp.c
index ecc1db0f900b6b800b41765b903f3b528ca93776..33f586492f0c25d6a053bba7c11b05457d257954 100644 (file)
--- a/esp.c
+++ b/esp.c
@@ -446,7 +446,7 @@ void esp_close(struct openconnect_info *vpninfo)
 {
        /* We close and reopen the socket in case we roamed and our
           local IP address has changed. */
-       if (vpninfo->dtls_fd != -1) {
+       if (vpninfo->dtls_fd >= 0) {
                unmonitor_fd(vpninfo, dtls);
                closesocket(vpninfo->dtls_fd);
                vpninfo->dtls_fd = -1;