]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
irqchip/mvebu-gicp: Fix an IS_ERR() vs NULL check in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 19 Aug 2025 09:40:02 +0000 (12:40 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 24 Aug 2025 10:00:47 +0000 (12:00 +0200)
ioremap() never returns error pointers, it returns NULL on error.  Fix the
check to match.

Fixes: 3c3d7dbab2c7 ("irqchip/mvebu-gicp: Clear pending interrupts on init")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/aKRGcgMeaXm2TMIC@stanley.mountain
drivers/irqchip/irq-mvebu-gicp.c

index 54833717f8a70f3e2b6340ac7df696c68bb8a723..667bde3c651ff253a749db078c09bf7f8695bfc8 100644 (file)
@@ -238,7 +238,7 @@ static int mvebu_gicp_probe(struct platform_device *pdev)
        }
 
        base = ioremap(gicp->res->start, resource_size(gicp->res));
-       if (IS_ERR(base)) {
+       if (!base) {
                dev_err(&pdev->dev, "ioremap() failed. Unable to clear pending interrupts.\n");
        } else {
                for (i = 0; i < 64; i++)