spi: don't unoptimize message in spi_async()

Calling spi_maybe_unoptimize_message() in spi_async() is wrong because
the message is likely to be in the queue and not transferred yet. This
can corrupt the message while it is being used by the controller driver.

spi_maybe_unoptimize_message() is already called in the correct place
in spi_finalize_current_message() to balance the call to
spi_maybe_optimize_message() in spi_async().

Fixes: 7b1d87af14d9 ("spi: add spi_optimize_message() APIs")
Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20240708-spi-mux-fix-v1-1-6c8845193128@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index fc13fa19218955823caa883f5cef23ad62ef3a23..679ee414cbeac0211be81622dc8c910956e3d6cb 100644 (file)
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -4432,8 +4432,6 @@ int spi_async(struct spi_device *spi, struct spi_message *message)
 
        spin_unlock_irqrestore(&ctlr->bus_lock_spinlock, flags);
 
-       spi_maybe_unoptimize_message(message);
-
        return ret;
 }
 EXPORT_SYMBOL_GPL(spi_async);