]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
irqchip/gic-v3-its: Avoid parsing _indirect_ twice for Device table
authorZenghui Yu <yuzenghui@huawei.com>
Sun, 10 Feb 2019 05:24:10 +0000 (05:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 19:10:01 +0000 (20:10 +0100)
commit 8d565748b6035eeda18895c213396a4c9fac6a4c upstream.

In current logic, its_parse_indirect_baser() will be invoked twice
when allocating Device tables. Add a *break* to omit the unnecessary
and annoying (might be ...) invoking.

Fixes: 32bd44dc19de ("irqchip/gic-v3-its: Fix the incorrect parsing of VCPU table size")
Cc: stable@vger.kernel.org
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/irqchip/irq-gic-v3-its.c

index 15579cba1a88216977876aa060033a56cabe7bbd..78970cdf2ef66052b87046390a8aafd6c51f3dc0 100644 (file)
@@ -1893,6 +1893,8 @@ static int its_alloc_tables(struct its_node *its)
                        indirect = its_parse_indirect_baser(its, baser,
                                                            psz, &order,
                                                            its->device_ids);
+                       break;
+
                case GITS_BASER_TYPE_VCPU:
                        indirect = its_parse_indirect_baser(its, baser,
                                                            psz, &order,