]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
xfs/299: don't chmod the underlying mountpoints prior to mounting
authorDarrick J. Wong <darrick.wong@oracle.com>
Sat, 28 Jan 2017 17:38:19 +0000 (09:38 -0800)
committerEryu Guan <eguan@redhat.com>
Sat, 4 Feb 2017 06:16:01 +0000 (14:16 +0800)
It's silly to make $SCRATCH_MNT world writable just prior to mounting
the scratch device; instead, do it after the mount.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
tests/xfs/299

index d2670f87a76227bb993365b8997c305b239c8a40..997c5dc0cf4332bc26dfa4dd21fd2e528cf97a72 100755 (executable)
@@ -203,9 +203,6 @@ cat $tmp.mkfs >>$seqres.full
 # keep the blocksize and data size for dd later
 . $tmp.mkfs
 
-# non-root users need to be able to write to this filesystem
-chmod 777 $SCRATCH_MNT
-
 cat >$tmp.projects <<EOF
 1:$SCRATCH_MNT
 EOF
@@ -220,6 +217,10 @@ projid_file="$tmp.projid"
 echo "*** user, group, and project"
 _qmount_option "uquota,gquota,pquota"
 _qmount
+
+# non-root users need to be able to write to this filesystem
+chmod 777 $SCRATCH_MNT
+
 _exercise p
 _exercise g
 _exercise u