drm/i915: Optimize out redundant dbuf slice updates

if the new dbuf slices are a superset of the old
dbuf slices then we don't have to do anything in
intel_dbuf_post_plane_update(). Restructure the code
to skip such redundant dbuf slice updates. The main
benefit is slightly less confusing logs.

Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240402155016.13733-15-ville.syrjala@linux.intel.com

diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c b/drivers/gpu/drm/i915/display/skl_watermark.c
index 1b48009efe2b13f2a2228986438bfcd66528b125..50ec510651186752010d7ed48cb5ed48037e7571 100644 (file)
--- a/drivers/gpu/drm/i915/display/skl_watermark.c
+++ b/drivers/gpu/drm/i915/display/skl_watermark.c
@@ -3788,16 +3788,20 @@ void intel_dbuf_pre_plane_update(struct intel_atomic_state *state)
                intel_atomic_get_new_dbuf_state(state);
        const struct intel_dbuf_state *old_dbuf_state =
                intel_atomic_get_old_dbuf_state(state);
+       u8 old_slices, new_slices;
 
-       if (!new_dbuf_state ||
-           new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
+       if (!new_dbuf_state)
+               return;
+
+       old_slices = old_dbuf_state->enabled_slices;
+       new_slices = old_dbuf_state->enabled_slices | new_dbuf_state->enabled_slices;
+
+       if (old_slices == new_slices)
                return;
 
        WARN_ON(!new_dbuf_state->base.changed);
 
-       gen9_dbuf_slices_update(i915,
-                               old_dbuf_state->enabled_slices |
-                               new_dbuf_state->enabled_slices);
+       gen9_dbuf_slices_update(i915, new_slices);
 }
 
 void intel_dbuf_post_plane_update(struct intel_atomic_state *state)
@@ -3807,15 +3811,20 @@ void intel_dbuf_post_plane_update(struct intel_atomic_state *state)
                intel_atomic_get_new_dbuf_state(state);
        const struct intel_dbuf_state *old_dbuf_state =
                intel_atomic_get_old_dbuf_state(state);
+       u8 old_slices, new_slices;
 
-       if (!new_dbuf_state ||
-           new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
+       if (!new_dbuf_state)
+               return;
+
+       old_slices = old_dbuf_state->enabled_slices | new_dbuf_state->enabled_slices;
+       new_slices = new_dbuf_state->enabled_slices;
+
+       if (old_slices == new_slices)
                return;
 
        WARN_ON(!new_dbuf_state->base.changed);
 
-       gen9_dbuf_slices_update(i915,
-                               new_dbuf_state->enabled_slices);
+       gen9_dbuf_slices_update(i915, new_slices);
 }
 
 static int skl_watermark_ipc_status_show(struct seq_file *m, void *data)