drm/atomic: log drm_atomic_replace_property_blob_from_id() errors

Signed-off-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221019143736.267324-1-contact@emersion.fr

diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c
index d867e7f9f2cd5800132561a63e0deb51e5c41b9c..be40ff0bc45886715d338f16007eaf39b610fe7e 100644 (file)
--- a/drivers/gpu/drm/drm_atomic_uapi.c
+++ b/drivers/gpu/drm/drm_atomic_uapi.c
@@ -374,16 +374,25 @@ drm_atomic_replace_property_blob_from_id(struct drm_device *dev,
 
        if (blob_id != 0) {
                new_blob = drm_property_lookup_blob(dev, blob_id);
-               if (new_blob == NULL)
+               if (new_blob == NULL) {
+                       drm_dbg_atomic(dev,
+                                      "cannot find blob ID %llu\n", blob_id);
                        return -EINVAL;
+               }
 
                if (expected_size > 0 &&
                    new_blob->length != expected_size) {
+                       drm_dbg_atomic(dev,
+                                      "[BLOB:%d] length %zu different from expected %zu\n",
+                                      new_blob->base.id, new_blob->length, expected_size);
                        drm_property_blob_put(new_blob);
                        return -EINVAL;
                }
                if (expected_elem_size > 0 &&
                    new_blob->length % expected_elem_size != 0) {
+                       drm_dbg_atomic(dev,
+                                      "[BLOB:%d] length %zu not divisible by element size %zu\n",
+                                      new_blob->base.id, new_blob->length, expected_elem_size);
                        drm_property_blob_put(new_blob);
                        return -EINVAL;
                }