rtc: jz4740: Make sure clock provider gets removed

The jz4740 RTC driver registers a clock provider, but never removes it.
This leaves a stale clock provider behind that references freed clocks when
the device is unbound.

Use the managed `devm_of_clk_add_hw_provider()` instead of
`of_clk_add_hw_provider()` to make sure the provider gets automatically
removed on unbind.

Fixes: 5ddfa148de8c ("rtc: jz4740: Register clock provider for the CLK32K pin")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20230409162544.16155-1-lars@metafoo.de
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
index 59d279e3e6f5bb2c709d87c8cb8fed9bb9d55161..36453b008139b3d8897c8df47c087d794268f650 100644 (file)
--- a/drivers/rtc/rtc-jz4740.c
+++ b/drivers/rtc/rtc-jz4740.c
@@ -414,7 +414,8 @@ static int jz4740_rtc_probe(struct platform_device *pdev)
                        return dev_err_probe(dev, ret,
                                             "Unable to register clk32k clock\n");
 
-               ret = of_clk_add_hw_provider(np, of_clk_hw_simple_get, &rtc->clk32k);
+               ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
+                                                 &rtc->clk32k);
                if (ret)
                        return dev_err_probe(dev, ret,
                                             "Unable to register clk32k clock provider\n");