engine->i915 = i915;
        engine->gt = gt;
        engine->uncore = gt->uncore;
-       engine->hw_id = engine->guc_id = info->hw_id;
        engine->mmio_base = __engine_mmio_base(i915, info->mmio_bases);
+       engine->hw_id = info->hw_id;
+       engine->guc_id = MAKE_GUC_ID(info->class, info->instance);
 
        engine->class = info->class;
        engine->instance = info->instance;
 
        return flags;
 }
 
-static u32 guc_ctl_ctxinfo_flags(struct intel_guc *guc)
-{
-       u32 flags = 0;
-
-       if (intel_guc_submission_is_used(guc)) {
-               u32 ctxnum, base;
-
-               base = intel_guc_ggtt_offset(guc, guc->stage_desc_pool);
-               ctxnum = GUC_MAX_STAGE_DESCRIPTORS / 16;
-
-               base >>= PAGE_SHIFT;
-               flags |= (base << GUC_CTL_BASE_ADDR_SHIFT) |
-                       (ctxnum << GUC_CTL_CTXNUM_IN16_SHIFT);
-       }
-       return flags;
-}
-
 static u32 guc_ctl_log_params_flags(struct intel_guc *guc)
 {
        u32 offset = intel_guc_ggtt_offset(guc, guc->log.vma) >> PAGE_SHIFT;
 
        BUILD_BUG_ON(sizeof(guc->params) != GUC_CTL_MAX_DWORDS * sizeof(u32));
 
-       params[GUC_CTL_CTXINFO] = guc_ctl_ctxinfo_flags(guc);
        params[GUC_CTL_LOG_PARAMS] = guc_ctl_log_params_flags(guc);
        params[GUC_CTL_FEATURE] = guc_ctl_feature_flags(guc);
        params[GUC_CTL_DEBUG] = guc_ctl_debug_flags(guc);
 
 
 /*
  * The Additional Data Struct (ADS) has pointers for different buffers used by
- * the GuC. One single gem object contains the ADS struct itself (guc_ads), the
- * scheduling policies (guc_policies), a structure describing a collection of
- * register sets (guc_mmio_reg_state) and some extra pages for the GuC to save
- * its internal state for sleep.
+ * the GuC. One single gem object contains the ADS struct itself (guc_ads) and
+ * all the extra buffers indirectly linked via the ADS struct's entries.
+ *
+ * Layout of the ADS blob allocated for the GuC:
+ *
+ *      +---------------------------------------+ <== base
+ *      | guc_ads                               |
+ *      +---------------------------------------+
+ *      | guc_policies                          |
+ *      +---------------------------------------+
+ *      | guc_gt_system_info                    |
+ *      +---------------------------------------+
+ *      | guc_clients_info                      |
+ *      +---------------------------------------+
+ *      | guc_ct_pool_entry[size]               |
+ *      +---------------------------------------+
+ *      | padding                               |
+ *      +---------------------------------------+ <== 4K aligned
+ *      | private data                          |
+ *      +---------------------------------------+
+ *      | padding                               |
+ *      +---------------------------------------+ <== 4K aligned
  */
+struct __guc_ads_blob {
+       struct guc_ads ads;
+       struct guc_policies policies;
+       struct guc_gt_system_info system_info;
+       struct guc_clients_info clients_info;
+       struct guc_ct_pool_entry ct_pool[GUC_CT_POOL_SIZE];
+} __packed;
+
+static u32 guc_ads_private_data_size(struct intel_guc *guc)
+{
+       return PAGE_ALIGN(guc->fw.private_data_size);
+}
+
+static u32 guc_ads_private_data_offset(struct intel_guc *guc)
+{
+       return PAGE_ALIGN(sizeof(struct __guc_ads_blob));
+}
+
+static u32 guc_ads_blob_size(struct intel_guc *guc)
+{
+       return guc_ads_private_data_offset(guc) +
+              guc_ads_private_data_size(guc);
+}
 
 static void guc_policy_init(struct guc_policy *policy)
 {
        memset(pool, 0, num * sizeof(*pool));
 }
 
+static void guc_mapping_table_init(struct intel_gt *gt,
+                                  struct guc_gt_system_info *system_info)
+{
+       unsigned int i, j;
+       struct intel_engine_cs *engine;
+       enum intel_engine_id id;
+
+       /* Table must be set to invalid values for entries not used */
+       for (i = 0; i < GUC_MAX_ENGINE_CLASSES; ++i)
+               for (j = 0; j < GUC_MAX_INSTANCES_PER_CLASS; ++j)
+                       system_info->mapping_table[i][j] =
+                               GUC_MAX_INSTANCES_PER_CLASS;
+
+       for_each_engine(engine, gt, id) {
+               u8 guc_class = engine->class;
+
+               system_info->mapping_table[guc_class][engine->instance] =
+                       engine->instance;
+       }
+}
+
 /*
  * The first 80 dwords of the register state context, containing the
  * execlists and ppgtt registers.
  */
 #define LR_HW_CONTEXT_SIZE     (80 * sizeof(u32))
 
-/* The ads obj includes the struct itself and buffers passed to GuC */
-struct __guc_ads_blob {
-       struct guc_ads ads;
-       struct guc_policies policies;
-       struct guc_mmio_reg_state reg_state;
-       struct guc_gt_system_info system_info;
-       struct guc_clients_info clients_info;
-       struct guc_ct_pool_entry ct_pool[GUC_CT_POOL_SIZE];
-       u8 reg_state_buffer[GUC_S3_SAVE_SPACE_PAGES * PAGE_SIZE];
-} __packed;
-
 static void __guc_ads_init(struct intel_guc *guc)
 {
        struct intel_gt *gt = guc_to_gt(guc);
+       struct drm_i915_private *i915 = gt->i915;
        struct __guc_ads_blob *blob = guc->ads_blob;
        const u32 skipped_size = LRC_PPHWSP_SZ * PAGE_SIZE + LR_HW_CONTEXT_SIZE;
        u32 base;
        }
 
        /* System info */
-       blob->system_info.slice_enabled = hweight8(gt->info.sseu.slice_mask);
-       blob->system_info.rcs_enabled = 1;
-       blob->system_info.bcs_enabled = 1;
+       blob->system_info.engine_enabled_masks[RENDER_CLASS] = 1;
+       blob->system_info.engine_enabled_masks[COPY_ENGINE_CLASS] = 1;
+       blob->system_info.engine_enabled_masks[VIDEO_DECODE_CLASS] = VDBOX_MASK(gt);
+       blob->system_info.engine_enabled_masks[VIDEO_ENHANCEMENT_CLASS] = VEBOX_MASK(gt);
+
+       blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_SLICE_ENABLED] =
+               hweight8(gt->info.sseu.slice_mask);
+       blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK] =
+               gt->info.vdbox_sfc_access;
+
+       if (INTEL_GEN(i915) >= 12 && !IS_DGFX(i915)) {
+               u32 distdbreg = intel_uncore_read(gt->uncore,
+                                                 GEN12_DIST_DBS_POPULATED);
+               blob->system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI] =
+                       ((distdbreg >> GEN12_DOORBELLS_PER_SQIDI_SHIFT) &
+                        GEN12_DOORBELLS_PER_SQIDI) + 1;
+       }
 
-       blob->system_info.vdbox_enable_mask = VDBOX_MASK(gt);
-       blob->system_info.vebox_enable_mask = VEBOX_MASK(gt);
-       blob->system_info.vdbox_sfc_support_mask = gt->info.vdbox_sfc_access;
+       guc_mapping_table_init(guc_to_gt(guc), &blob->system_info);
 
        base = intel_guc_ggtt_offset(guc, guc->ads_vma);
 
 
        /* ADS */
        blob->ads.scheduler_policies = base + ptr_offset(blob, policies);
-       blob->ads.reg_state_buffer = base + ptr_offset(blob, reg_state_buffer);
-       blob->ads.reg_state_addr = base + ptr_offset(blob, reg_state);
        blob->ads.gt_system_info = base + ptr_offset(blob, system_info);
        blob->ads.clients_info = base + ptr_offset(blob, clients_info);
 
+       /* Private Data */
+       blob->ads.private_data = base + guc_ads_private_data_offset(guc);
+
        i915_gem_object_flush_map(guc->ads_vma->obj);
 }
 
  */
 int intel_guc_ads_create(struct intel_guc *guc)
 {
-       const u32 size = PAGE_ALIGN(sizeof(struct __guc_ads_blob));
+       u32 size;
        int ret;
 
        GEM_BUG_ON(guc->ads_vma);
 
+       size = guc_ads_blob_size(guc);
+
        ret = intel_guc_allocate_and_map_vma(guc, size, &guc->ads_vma,
                                             (void **)&guc->ads_blob);
-
        if (ret)
                return ret;
 
        i915_vma_unpin_and_release(&guc->ads_vma, I915_VMA_RELEASE_MAP);
 }
 
+static void guc_ads_private_data_reset(struct intel_guc *guc)
+{
+       u32 size;
+
+       size = guc_ads_private_data_size(guc);
+       if (!size)
+               return;
+
+       memset((void *)guc->ads_blob + guc_ads_private_data_offset(guc), 0,
+              size);
+}
+
 /**
  * intel_guc_ads_reset() - prepares GuC Additional Data Struct for reuse
  * @guc: intel_guc struct
 {
        if (!guc->ads_vma)
                return;
+
        __guc_ads_init(guc);
+
+       guc_ads_private_data_reset(guc);
 }
 
 #define GUC_VIDEO_ENGINE2              4
 #define GUC_MAX_ENGINES_NUM            (GUC_VIDEO_ENGINE2 + 1)
 
-#define GUC_MAX_ENGINE_CLASSES         5
-#define GUC_MAX_INSTANCES_PER_CLASS    16
+#define GUC_MAX_ENGINE_CLASSES         16
+#define GUC_MAX_INSTANCES_PER_CLASS    32
 
 #define GUC_DOORBELL_INVALID           256
 
 #define GUC_STAGE_DESC_ATTR_PCH                BIT(6)
 #define GUC_STAGE_DESC_ATTR_TERMINATED BIT(7)
 
-/* New GuC control data */
-#define GUC_CTL_CTXINFO                        0
-#define   GUC_CTL_CTXNUM_IN16_SHIFT    0
-#define   GUC_CTL_BASE_ADDR_SHIFT      12
-
-#define GUC_CTL_LOG_PARAMS             1
+#define GUC_CTL_LOG_PARAMS             0
 #define   GUC_LOG_VALID                        (1 << 0)
 #define   GUC_LOG_NOTIFY_ON_HALF_FULL  (1 << 1)
 #define   GUC_LOG_ALLOC_IN_MEGABYTE    (1 << 3)
 #define   GUC_LOG_ISR_MASK             (0x7 << GUC_LOG_ISR_SHIFT)
 #define   GUC_LOG_BUF_ADDR_SHIFT       12
 
-#define GUC_CTL_WA                     2
-#define GUC_CTL_FEATURE                        3
+#define GUC_CTL_WA                     1
+#define GUC_CTL_FEATURE                        2
 #define   GUC_CTL_DISABLE_SCHEDULER    (1 << 14)
 
-#define GUC_CTL_DEBUG                  4
+#define GUC_CTL_DEBUG                  3
 #define   GUC_LOG_VERBOSITY_SHIFT      0
 #define   GUC_LOG_VERBOSITY_LOW                (0 << GUC_LOG_VERBOSITY_SHIFT)
 #define   GUC_LOG_VERBOSITY_MED                (1 << GUC_LOG_VERBOSITY_SHIFT)
 #define   GUC_LOG_DISABLED             (1 << 6)
 #define   GUC_PROFILE_ENABLED          (1 << 7)
 
-#define GUC_CTL_ADS                    5
+#define GUC_CTL_ADS                    4
 #define   GUC_ADS_ADDR_SHIFT           1
 #define   GUC_ADS_ADDR_MASK            (0xFFFFF << GUC_ADS_ADDR_SHIFT)
 
 #define GUC_CTL_MAX_DWORDS             (SOFT_SCRATCH_COUNT - 2) /* [1..14] */
 
+/* Generic GT SysInfo data types */
+#define GUC_GENERIC_GT_SYSINFO_SLICE_ENABLED           0
+#define GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK  1
+#define GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI        2
+#define GUC_GENERIC_GT_SYSINFO_MAX                     16
+
+/*
+ * The class goes in bits [0..2] of the GuC ID, the instance in bits [3..6].
+ * Bit 7 can be used for operations that apply to all engine classes&instances.
+ */
+#define GUC_ENGINE_CLASS_SHIFT         0
+#define GUC_ENGINE_CLASS_MASK          (0x7 << GUC_ENGINE_CLASS_SHIFT)
+#define GUC_ENGINE_INSTANCE_SHIFT      3
+#define GUC_ENGINE_INSTANCE_MASK       (0xf << GUC_ENGINE_INSTANCE_SHIFT)
+#define GUC_ENGINE_ALL_INSTANCES       BIT(7)
+
+#define MAKE_GUC_ID(class, instance) \
+       (((class) << GUC_ENGINE_CLASS_SHIFT) | \
+        ((instance) << GUC_ENGINE_INSTANCE_SHIFT))
+
+#define GUC_ID_TO_ENGINE_CLASS(guc_id) \
+       (((guc_id) & GUC_ENGINE_CLASS_MASK) >> GUC_ENGINE_CLASS_SHIFT)
+#define GUC_ID_TO_ENGINE_INSTANCE(guc_id) \
+       (((guc_id) & GUC_ENGINE_INSTANCE_MASK) >> GUC_ENGINE_INSTANCE_SHIFT)
+
 /* Work item for submitting workloads into work queue of GuC. */
 struct guc_wq_item {
        u32 header;
 } __packed;
 
 /* GuC MMIO reg state struct */
-
-
-#define GUC_REGSET_MAX_REGISTERS       64
-#define GUC_S3_SAVE_SPACE_PAGES                10
-
 struct guc_mmio_reg {
        u32 offset;
        u32 value;
 #define GUC_REGSET_MASKED              (1 << 0)
 } __packed;
 
-struct guc_mmio_regset {
-       struct guc_mmio_reg registers[GUC_REGSET_MAX_REGISTERS];
-       u32 values_valid;
-       u32 number_of_registers;
-} __packed;
-
 /* GuC register sets */
-struct guc_mmio_reg_state {
-       struct guc_mmio_regset engine_reg[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];
-       u32 reserved[98];
+struct guc_mmio_reg_set {
+       u32 address;
+       u16 count;
+       u16 reserved;
 } __packed;
 
 /* HW info */
 struct guc_gt_system_info {
-       u32 slice_enabled;
-       u32 rcs_enabled;
-       u32 reserved0;
-       u32 bcs_enabled;
-       u32 vdbox_enable_mask;
-       u32 vdbox_sfc_support_mask;
-       u32 vebox_enable_mask;
-       u32 reserved[9];
+       u8 mapping_table[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];
+       u32 engine_enabled_masks[GUC_MAX_ENGINE_CLASSES];
+       u32 generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_MAX];
 } __packed;
 
 /* Clients info */
 
 /* GuC Additional Data Struct */
 struct guc_ads {
-       u32 reg_state_addr;
-       u32 reg_state_buffer;
+       struct guc_mmio_reg_set reg_state_list[GUC_MAX_ENGINE_CLASSES][GUC_MAX_INSTANCES_PER_CLASS];
+       u32 reserved0;
        u32 scheduler_policies;
        u32 gt_system_info;
        u32 clients_info;
        u32 control_data;
        u32 golden_context_lrca[GUC_MAX_ENGINE_CLASSES];
        u32 eng_state_size[GUC_MAX_ENGINE_CLASSES];
-       u32 reserved[16];
+       u32 private_data;
+       u32 reserved[15];
 } __packed;
 
 /* GuC logging structures */
 
 #define   GEN8_DRB_VALID                 (1<<0)
 #define GEN8_DRBREGU(x)                        _MMIO(0x1000 + (x) * 8 + 4)
 
+#define GEN12_DIST_DBS_POPULATED               _MMIO(0xd08)
+#define   GEN12_DOORBELLS_PER_SQIDI_SHIFT      16
+#define   GEN12_DOORBELLS_PER_SQIDI            (0xff)
+#define   GEN12_SQIDIS_DOORBELL_EXIST          (0xffff)
+
 #define DE_GUCRMR                      _MMIO(0x44054)
 
 #define GUC_BCS_RCS_IER                        _MMIO(0xC550)
 
  * List of required GuC and HuC binaries per-platform.
  * Must be ordered based on platform + revid, from newer to older.
  *
- * TGL 35.2 is interface-compatible with 33.0 for previous Gens. The deltas
- * between 33.0 and 35.2 are only related to new additions to support new Gen12
- * features.
- *
  * Note that RKL uses the same firmware as TGL.
  */
 #define INTEL_UC_FIRMWARE_DEFS(fw_def, guc_def, huc_def) \
-       fw_def(ROCKETLAKE,  0, guc_def(tgl, 35, 2, 0), huc_def(tgl,  7, 5, 0)) \
-       fw_def(TIGERLAKE,   0, guc_def(tgl, 35, 2, 0), huc_def(tgl,  7, 5, 0)) \
-       fw_def(ELKHARTLAKE, 0, guc_def(ehl, 33, 0, 4), huc_def(ehl,  9, 0, 0)) \
-       fw_def(ICELAKE,     0, guc_def(icl, 33, 0, 0), huc_def(icl,  9, 0, 0)) \
-       fw_def(COMETLAKE,   5, guc_def(cml, 33, 0, 0), huc_def(cml,  4, 0, 0)) \
-       fw_def(COFFEELAKE,  0, guc_def(kbl, 33, 0, 0), huc_def(kbl,  4, 0, 0)) \
-       fw_def(GEMINILAKE,  0, guc_def(glk, 33, 0, 0), huc_def(glk,  4, 0, 0)) \
-       fw_def(KABYLAKE,    0, guc_def(kbl, 33, 0, 0), huc_def(kbl,  4, 0, 0)) \
-       fw_def(BROXTON,     0, guc_def(bxt, 33, 0, 0), huc_def(bxt,  2, 0, 0)) \
-       fw_def(SKYLAKE,     0, guc_def(skl, 33, 0, 0), huc_def(skl,  2, 0, 0))
+       fw_def(ROCKETLAKE,  0, guc_def(tgl, 49, 0, 1), huc_def(tgl,  7, 5, 0)) \
+       fw_def(TIGERLAKE,   0, guc_def(tgl, 49, 0, 1), huc_def(tgl,  7, 5, 0)) \
+       fw_def(ELKHARTLAKE, 0, guc_def(ehl, 49, 0, 1), huc_def(ehl,  9, 0, 0)) \
+       fw_def(ICELAKE,     0, guc_def(icl, 49, 0, 1), huc_def(icl,  9, 0, 0)) \
+       fw_def(COMETLAKE,   5, guc_def(cml, 49, 0, 1), huc_def(cml,  4, 0, 0)) \
+       fw_def(COFFEELAKE,  0, guc_def(kbl, 49, 0, 1), huc_def(kbl,  4, 0, 0)) \
+       fw_def(GEMINILAKE,  0, guc_def(glk, 49, 0, 1), huc_def(glk,  4, 0, 0)) \
+       fw_def(KABYLAKE,    0, guc_def(kbl, 49, 0, 1), huc_def(kbl,  4, 0, 0)) \
+       fw_def(BROXTON,     0, guc_def(bxt, 49, 0, 1), huc_def(bxt,  2, 0, 0)) \
+       fw_def(SKYLAKE,     0, guc_def(skl, 49, 0, 1), huc_def(skl,  2, 0, 0))
 
 #define __MAKE_UC_FW_PATH(prefix_, name_, major_, minor_, patch_) \
        "i915/" \
                }
        }
 
+       if (uc_fw->type == INTEL_UC_FW_TYPE_GUC)
+               uc_fw->private_data_size = css->private_data_size;
+
        obj = i915_gem_object_create_shmem_from_data(i915, fw->data, fw->size);
        if (IS_ERR(obj)) {
                err = PTR_ERR(obj);
 
 
        u32 rsa_size;
        u32 ucode_size;
+
+       u32 private_data_size;
 };
 
 #ifdef CONFIG_DRM_I915_DEBUG_GUC
 
 #define CSS_SW_VERSION_UC_MAJOR                (0xFF << 16)
 #define CSS_SW_VERSION_UC_MINOR                (0xFF << 8)
 #define CSS_SW_VERSION_UC_PATCH                (0xFF << 0)
-       u32 reserved[14];
+       u32 reserved0[13];
+       union {
+               u32 private_data_size; /* only applies to GuC */
+               u32 reserved1;
+       };
        u32 header_info;
 } __packed;
 static_assert(sizeof(struct uc_css_header) == 128);