]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
leds: bcm6328, bcm6358: use devres LED registering function
authorMarek Behún <marek.behun@nic.cz>
Thu, 17 Sep 2020 22:32:58 +0000 (00:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:08:46 +0000 (11:08 +0100)
commit ff5c89d44453e7ad99502b04bf798a3fc32c758b upstream.

These two drivers do not provide remove method and use devres for
allocation of other resources, yet they use led_classdev_register
instead of the devres variant, devm_led_classdev_register.

Fix this.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Álvaro Fernández Rojas <noltari@gmail.com>
Cc: Kevin Cernekee <cernekee@gmail.com>
Cc: Jaedon Shin <jaedon.shin@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/leds/leds-bcm6328.c
drivers/leds/leds-bcm6358.c

index 2cfd9389ee96f8cc69a40681374a19a31aa174ed..b944ae828004a42690800ff920b46023fa99e812 100644 (file)
@@ -336,7 +336,7 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
        led->cdev.brightness_set = bcm6328_led_set;
        led->cdev.blink_set = bcm6328_blink_set;
 
-       rc = led_classdev_register(dev, &led->cdev);
+       rc = devm_led_classdev_register(dev, &led->cdev);
        if (rc < 0)
                return rc;
 
index b2cc06618abed309beaa7b0533cdb8b5b0762ff9..a86ab6197a4ea39adeab81f03455e1fd78b18dd1 100644 (file)
@@ -141,7 +141,7 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
 
        led->cdev.brightness_set = bcm6358_led_set;
 
-       rc = led_classdev_register(dev, &led->cdev);
+       rc = devm_led_classdev_register(dev, &led->cdev);
        if (rc < 0)
                return rc;