]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
hw/i386: make explicit clearing of pch_rev_id
authorAlex Bennée <alex.bennee@linaro.org>
Wed, 9 Sep 2020 11:27:38 +0000 (12:27 +0100)
committerAlex Bennée <alex.bennee@linaro.org>
Thu, 10 Sep 2020 09:44:01 +0000 (10:44 +0100)
Some compilers (notably the Xenial gcc in Travis) fail to spot that
this will always be set if pch_dev_id != 0xffff. Given this is setup
code and using _Pragma to override is equally as ugly lets just remove
the doubt from the compilers mind.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200909112742.25730-8-alex.bennee@linaro.org>

hw/i386/pc_piix.c

index 32b1453e6a8261de636136d1f430cd07c39e58f8..33fa035fb7fef41150ff1c3cc95750b62fb76193 100644 (file)
@@ -930,7 +930,7 @@ void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id)
     struct PCIDevice *bridge_dev;
     int i, num;
     uint16_t pch_dev_id = 0xffff;
-    uint8_t pch_rev_id;
+    uint8_t pch_rev_id = 0;
 
     num = ARRAY_SIZE(igd_combo_id_infos);
     for (i = 0; i < num; i++) {