]> www.infradead.org Git - linux.git/commitdiff
linux/interrupt.h: allow "guard" notation to disable and reenable IRQ
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 30 May 2024 18:07:19 +0000 (11:07 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 6 Jun 2024 21:35:01 +0000 (14:35 -0700)
Drivers often need to first disable an interrupt, carry out some
action, and then reenable the interrupt. Introduce support for the
"guard" notation for this so that the following is possible:

...

scoped_cond_guard(mutex_intr, return -EINTR, &data->sysfs_mutex) {
guard(disable_irq)(&client->irq);

error = elan_acquire_baseline(data);
if (error)
return error;
}

...

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/ZljAV6HjkPSEhWSw@google.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
include/linux/interrupt.h

index 5c9bdd3ffccc89254fcc31c1b1f34d81f8374234..3a36e64119c8c64d8253279078426265df43c6b9 100644 (file)
@@ -5,6 +5,7 @@
 
 #include <linux/kernel.h>
 #include <linux/bitops.h>
+#include <linux/cleanup.h>
 #include <linux/cpumask.h>
 #include <linux/irqreturn.h>
 #include <linux/irqnr.h>
@@ -235,6 +236,9 @@ extern void enable_percpu_irq(unsigned int irq, unsigned int type);
 extern bool irq_percpu_is_enabled(unsigned int irq);
 extern void irq_wake_thread(unsigned int irq, void *dev_id);
 
+DEFINE_LOCK_GUARD_1(disable_irq, int,
+                   disable_irq(*_T->lock), enable_irq(*_T->lock))
+
 extern void disable_nmi_nosync(unsigned int irq);
 extern void disable_percpu_nmi(unsigned int irq);
 extern void enable_nmi(unsigned int irq);