]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ASoC: qdsp6: audioreach: Fix clang -Wimplicit-fallthrough
authorNathan Chancellor <nathan@kernel.org>
Wed, 27 Oct 2021 19:08:23 +0000 (12:08 -0700)
committerMark Brown <broonie@kernel.org>
Thu, 28 Oct 2021 12:28:18 +0000 (13:28 +0100)
Clang warns:

sound/soc/qcom/qdsp6/topology.c:465:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
                default:
                ^
sound/soc/qcom/qdsp6/topology.c:465:3: note: insert 'break;' to avoid fall-through
                default:
                ^
                break;
1 warning generated.

Clang is a little more pedantic than GCC, which permits implicit
fallthroughs to cases that contain just break or return. Clang's version
is more in line with the kernel's own stance in deprecated.rst, which
states that all switch/case blocks must end in either break,
fallthrough, continue, goto, or return. Add the missing break to fix
the warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1495
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20211027190823.4057382-1-nathan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/topology.c

index f3189537992590312a81d18ccb63e401d58a59ae..bd649c232a0611817406fda015ade9e16b14f6d0 100644 (file)
@@ -461,7 +461,7 @@ static struct audioreach_module *audioreach_parse_common_tokens(struct q6apm *ap
                        break;
                case AR_TKN_U32_MODULE_DST_IN_PORT_ID:
                        dst_mod_ip_port_id = le32_to_cpu(mod_elem->value);
-
+                       break;
                default:
                        break;