]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mm, slub: discard slabs in unfreeze_partials() without irqs disabled
authorVlastimil Babka <vbabka@suse.cz>
Mon, 23 Aug 2021 23:59:00 +0000 (09:59 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 25 Aug 2021 23:33:30 +0000 (09:33 +1000)
No need for disabled irqs when discarding slabs, so restore them before
discarding.

Link: https://lkml.kernel.org/r/20210805152000.12817-24-vbabka@suse.cz
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Lameter <cl@linux.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Jann Horn <jannh@google.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
mm/slub.c

index b1c120d3d461a1d38b840ac5dfecc63a5c6fcfcd..240b22328212b0aeab7f4423da28b22afa4f9109 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -2392,6 +2392,8 @@ static void unfreeze_partials(struct kmem_cache *s,
        if (n)
                spin_unlock(&n->list_lock);
 
+       local_irq_restore(flags);
+
        while (discard_page) {
                page = discard_page;
                discard_page = discard_page->next;
@@ -2401,7 +2403,6 @@ static void unfreeze_partials(struct kmem_cache *s,
                stat(s, FREE_SLAB);
        }
 
-       local_irq_restore(flags);
 #endif /* CONFIG_SLUB_CPU_PARTIAL */
 }