]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
selftests: mm: check return values
authorMuhammad Usama Anjum <usama.anjum@collabora.com>
Mon, 20 May 2024 18:52:48 +0000 (11:52 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 4 Jul 2024 02:29:56 +0000 (19:29 -0700)
Check return value and return error/skip the tests.

Link: https://lkml.kernel.org/r/20240520185248.1801945-1-usama.anjum@collabora.com
Fixes: 46fd75d4a3c9 ("selftests: mm: add pagemap ioctl tests")
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Shuah Khan <shuah@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/testing/selftests/mm/pagemap_ioctl.c

index 2d785aca72a5c250e0306c7e11f678d5af7f0bdb..bcc73b4e805c68845176b0a11dc44361f29c3866 100644 (file)
@@ -1567,8 +1567,10 @@ int main(int argc, char *argv[])
        /* 7. File Hugetlb testing */
        mem_size = 2*1024*1024;
        fd = memfd_create("uffd-test", MFD_HUGETLB | MFD_NOEXEC_SEAL);
+       if (fd < 0)
+               ksft_exit_fail_msg("uffd-test creation failed %d %s\n", errno, strerror(errno));
        mem = mmap(NULL, mem_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
-       if (mem) {
+       if (mem != MAP_FAILED) {
                wp_init(mem, mem_size);
                wp_addr_range(mem, mem_size);