]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
brcmfmac: Fix memory leak in brcmf_usbdev_qinit
authorNavid Emamdoost <navid.emamdoost@gmail.com>
Sun, 15 Dec 2019 01:51:14 +0000 (19:51 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Feb 2020 12:36:40 +0000 (04:36 -0800)
commit 4282dc057d750c6a7dd92953564b15c26b54c22c upstream.

In the implementation of brcmf_usbdev_qinit() the allocated memory for
reqs is leaking if usb_alloc_urb() fails. Release reqs in the error
handling path.

Fixes: 71bb244ba2fd ("brcm80211: fmac: add USB support for bcm43235/6/8 chipsets")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c

index 7cdfde9b3dea90ca36366cd80334e0965a0244ec..575ed19e91951f0acbc9b861e78a81f15b67e5f3 100644 (file)
@@ -430,6 +430,7 @@ fail:
                        usb_free_urb(req->urb);
                list_del(q->next);
        }
+       kfree(reqs);
        return NULL;
 
 }