]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
net: txgbe: fix i2c dev name cannot match clkdev
authorDuanqiang Wen <duanqiangwen@net-swift.com>
Tue, 2 Apr 2024 02:18:43 +0000 (10:18 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Apr 2024 02:21:04 +0000 (19:21 -0700)
txgbe clkdev shortened clk_name, so i2c_dev info_name
also need to shorten. Otherwise, i2c_dev cannot initialize
clock.

Fixes: e30cef001da2 ("net: txgbe: fix clk_name exceed MAX_DEV_ID limits")
Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com>
Link: https://lore.kernel.org/r/20240402021843.126192-1-duanqiangwen@net-swift.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c

index 5b5d5e4310d127189cfdea18223f02460a6af149..2fa511227eac8490314c09821c7b6f1e1fdfed43 100644 (file)
@@ -20,6 +20,8 @@
 #include "txgbe_phy.h"
 #include "txgbe_hw.h"
 
+#define TXGBE_I2C_CLK_DEV_NAME "i2c_dw"
+
 static int txgbe_swnodes_register(struct txgbe *txgbe)
 {
        struct txgbe_nodes *nodes = &txgbe->nodes;
@@ -571,8 +573,8 @@ static int txgbe_clock_register(struct txgbe *txgbe)
        char clk_name[32];
        struct clk *clk;
 
-       snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d",
-                pci_dev_id(pdev));
+       snprintf(clk_name, sizeof(clk_name), "%s.%d",
+                TXGBE_I2C_CLK_DEV_NAME, pci_dev_id(pdev));
 
        clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000);
        if (IS_ERR(clk))
@@ -634,7 +636,7 @@ static int txgbe_i2c_register(struct txgbe *txgbe)
 
        info.parent = &pdev->dev;
        info.fwnode = software_node_fwnode(txgbe->nodes.group[SWNODE_I2C]);
-       info.name = "i2c_designware";
+       info.name = TXGBE_I2C_CLK_DEV_NAME;
        info.id = pci_dev_id(pdev);
 
        info.res = &DEFINE_RES_IRQ(pdev->irq);