]> www.infradead.org Git - nvme.git/commitdiff
bcachefs: Fix srcu warning in check_topology
authorKent Overstreet <kent.overstreet@linux.dev>
Mon, 23 Sep 2024 22:42:39 +0000 (18:42 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sat, 28 Sep 2024 01:46:34 +0000 (21:46 -0400)
check_topology doesn't need the srcu lock and doesn't use normal btree
transactions - we can just drop the srcu lock.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_gc.c

index b5e0692f03c6811ddc48f3b3e56bab2f7b400530..40b08fef3c398dbbe0b66ae273933b5b29c48529 100644 (file)
@@ -513,6 +513,8 @@ int bch2_check_topology(struct bch_fs *c)
        struct bpos pulled_from_scan = POS_MIN;
        int ret = 0;
 
+       bch2_trans_srcu_unlock(trans);
+
        for (unsigned i = 0; i < btree_id_nr_alive(c) && !ret; i++) {
                struct btree_root *r = bch2_btree_id_root(c, i);
                bool reconstructed_root = false;