]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
io_uring/rw: always clear ->bytes_done on io_async_rw setup
authorJens Axboe <axboe@kernel.dk>
Fri, 27 Dec 2024 16:49:32 +0000 (09:49 -0700)
committerJens Axboe <axboe@kernel.dk>
Fri, 27 Dec 2024 17:09:34 +0000 (10:09 -0700)
A previous commit mistakenly moved the clearing of the in-progress byte
count into the section that's dependent on having a cached iovec or not,
but it should be cleared for any IO. If not, then extra bytes may be
added at IO completion time, causing potentially weird behavior like
over-reporting the amount of IO done.

Fixes: d7f11616edf5 ("io_uring/rw: Allocate async data through helper")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202412271132.a09c3500-lkp@intel.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/rw.c

index 75f70935ccf47de96dad11da3cefc371fe5a0bc2..ca1b19d3d14231a325113ad47949d13eba236230 100644 (file)
@@ -228,8 +228,8 @@ static int io_rw_alloc_async(struct io_kiocb *req)
                kasan_mempool_unpoison_object(rw->free_iovec,
                                              rw->free_iov_nr * sizeof(struct iovec));
                req->flags |= REQ_F_NEED_CLEANUP;
-               rw->bytes_done = 0;
        }
+       rw->bytes_done = 0;
        return 0;
 }