net: stmmac: dwmac-qcom-ethqos: Drop an if with an always false condition

The remove callback is only ever called after .probe() returned
successfully. After that get_stmmac_bsp_priv() always return non-NULL.

Side note: The early exit would also be a bug because the return value
of qcom_ethqos_remove() is ignored by the device core and the device is
unbound unconditionally. So exiting early resulted in a dangerous
resource leak as all devm allocated resources (some memory and the
register mappings) are freed but the network device stays around.  Using
the network device afterwards probably oopses.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index 494c222432590ddad49b23a04793f84db7dacd5e..bf17c6c8f2ebb9d22c2bfd34339653a330952da2 100644 (file)
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -667,11 +667,7 @@ err_mem:
 
 static int qcom_ethqos_remove(struct platform_device *pdev)
 {
-       struct qcom_ethqos *ethqos;
-
-       ethqos = get_stmmac_bsp_priv(&pdev->dev);
-       if (!ethqos)
-               return -ENODEV;
+       struct qcom_ethqos *ethqos = get_stmmac_bsp_priv(&pdev->dev);
 
        stmmac_pltfr_remove(pdev);
        ethqos_clks_config(ethqos, false);