]> www.infradead.org Git - users/hch/misc.git/commitdiff
Octeontx2-af: Fix missing error code in cgx_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fri, 10 Oct 2025 20:42:39 +0000 (13:42 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 14 Oct 2025 09:47:31 +0000 (11:47 +0200)
When CGX fails mapping to NIX, set the error code to -ENODEV, currently
err is zero and that is treated as success path.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aLAdlCg2_Yv7Y-3h@stanley.mountain/
Fixes: d280233fc866 ("Octeontx2-af: Fix NIX X2P calibration failures")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251010204239.94237-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/marvell/octeontx2/af/cgx.c

index d374a4454836b7ae4ef99782d403393b0ac54862..ec0e11c77cbf20f2e2211059f04d0765500a2455 100644 (file)
@@ -1981,6 +1981,7 @@ static int cgx_probe(struct pci_dev *pdev, const struct pci_device_id *id)
            !is_cgx_mapped_to_nix(pdev->subsystem_device, cgx->cgx_id)) {
                dev_notice(dev, "CGX %d not mapped to NIX, skipping probe\n",
                           cgx->cgx_id);
+               err = -ENODEV;
                goto err_release_regions;
        }