]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
thunderbolt: Debug log an invalid config space reply just once
authorMika Westerberg <mika.westerberg@linux.intel.com>
Mon, 2 Sep 2024 08:17:13 +0000 (11:17 +0300)
committerMika Westerberg <mika.westerberg@linux.intel.com>
Fri, 3 Jan 2025 09:50:08 +0000 (11:50 +0200)
These can mess up the debug log if a router does not implement the
config space register blocks fully and we are reading registers through
debugfs. To avoid this, just log it once.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/thunderbolt/ctl.c

index fd40cda1e53fa127325277430d6a89353a6dbf25..dc1f456736dc4606d6d1e2a51cedf8ffd6149182 100644 (file)
@@ -70,6 +70,9 @@ struct tb_ctl {
 #define tb_ctl_dbg(ctl, format, arg...) \
        dev_dbg(&(ctl)->nhi->pdev->dev, format, ## arg)
 
+#define tb_ctl_dbg_once(ctl, format, arg...) \
+       dev_dbg_once(&(ctl)->nhi->pdev->dev, format, ## arg)
+
 static DECLARE_WAIT_QUEUE_HEAD(tb_cfg_request_cancel_queue);
 /* Serializes access to request kref_get/put */
 static DEFINE_MUTEX(tb_cfg_request_lock);
@@ -279,8 +282,8 @@ static void tb_cfg_print_error(struct tb_ctl *ctl, enum tb_cfg_space space,
                 * Invalid cfg_space/offset/length combination in
                 * cfg_read/cfg_write.
                 */
-               tb_ctl_dbg(ctl, "%llx:%x: invalid config space (%u) or offset\n",
-                          res->response_route, res->response_port, space);
+               tb_ctl_dbg_once(ctl, "%llx:%x: invalid config space (%u) or offset\n",
+                               res->response_route, res->response_port, space);
                return;
        case TB_CFG_ERROR_NO_SUCH_PORT:
                /*