net: mscc: ocelot: consolidate cookie allocation for private VCAP rules

Every use case that needed VCAP filters (in order: DSA tag_8021q, MRP,
PTP traps) has hardcoded filter identifiers that worked well enough for
that use case alone. But when two or more of those use cases would be
used together, some of those identifiers would overlap, leading to
breakage.

Add definitions for each cookie and centralize them in ocelot_vcap.h,
such that the overlaps are more obvious.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c
index 9957772201d58d4fdc59f8b487bf9068bb70c811..c26f781f8df2d36d24d652ef674c727571c03eec 100644 (file)
--- a/drivers/net/dsa/ocelot/felix.c
+++ b/drivers/net/dsa/ocelot/felix.c
@@ -50,7 +50,7 @@ static int felix_tag_8021q_rxvlan_add(struct felix *felix, int port, u16 vid,
 
        outer_tagging_rule->key_type = OCELOT_VCAP_KEY_ANY;
        outer_tagging_rule->prio = 1;
-       outer_tagging_rule->id.cookie = port;
+       outer_tagging_rule->id.cookie = OCELOT_VCAP_ES0_TAG_8021Q_RXVLAN(ocelot, port);
        outer_tagging_rule->id.tc_offload = false;
        outer_tagging_rule->block_id = VCAP_ES0;
        outer_tagging_rule->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -103,7 +103,7 @@ static int felix_tag_8021q_txvlan_add(struct felix *felix, int port, u16 vid,
        untagging_rule->vlan.vid.value = vid;
        untagging_rule->vlan.vid.mask = VLAN_VID_MASK;
        untagging_rule->prio = 1;
-       untagging_rule->id.cookie = port;
+       untagging_rule->id.cookie = OCELOT_VCAP_IS1_TAG_8021Q_TXVLAN(ocelot, port);
        untagging_rule->id.tc_offload = false;
        untagging_rule->block_id = VCAP_IS1;
        untagging_rule->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -124,7 +124,7 @@ static int felix_tag_8021q_txvlan_add(struct felix *felix, int port, u16 vid,
        redirect_rule->ingress_port_mask = BIT(upstream);
        redirect_rule->pag = port;
        redirect_rule->prio = 1;
-       redirect_rule->id.cookie = port;
+       redirect_rule->id.cookie = OCELOT_VCAP_IS2_TAG_8021Q_TXVLAN(ocelot, port);
        redirect_rule->id.tc_offload = false;
        redirect_rule->block_id = VCAP_IS2;
        redirect_rule->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -308,7 +308,7 @@ static int felix_setup_mmio_filtering(struct felix *felix)
        *(__be16 *)tagging_rule->key.etype.etype.mask = htons(0xffff);
        tagging_rule->ingress_port_mask = user_ports;
        tagging_rule->prio = 1;
-       tagging_rule->id.cookie = ocelot->num_phys_ports;
+       tagging_rule->id.cookie = OCELOT_VCAP_IS1_TAG_8021Q_PTP_MMIO(ocelot);
        tagging_rule->id.tc_offload = false;
        tagging_rule->block_id = VCAP_IS1;
        tagging_rule->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -327,7 +327,7 @@ static int felix_setup_mmio_filtering(struct felix *felix)
        redirect_rule->ingress_port_mask = user_ports;
        redirect_rule->pag = ocelot->num_phys_ports;
        redirect_rule->prio = 1;
-       redirect_rule->id.cookie = ocelot->num_phys_ports;
+       redirect_rule->id.cookie = OCELOT_VCAP_IS2_TAG_8021Q_PTP_MMIO(ocelot);
        redirect_rule->id.tc_offload = false;
        redirect_rule->block_id = VCAP_IS2;
        redirect_rule->type = OCELOT_VCAP_FILTER_OFFLOAD;

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index 637fd79402e08fc53fde4bb07e979cff436cab4c..6039c9cb09c7daca207a9e50294acb2a37c79e03 100644 (file)
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -1537,7 +1537,7 @@ static int ocelot_trap_del(struct ocelot *ocelot, int port,
 
 static int ocelot_l2_ptp_trap_add(struct ocelot *ocelot, int port)
 {
-       unsigned long l2_cookie = ocelot->num_phys_ports + 1;
+       unsigned long l2_cookie = OCELOT_VCAP_IS2_L2_PTP_TRAP(ocelot);
 
        return ocelot_trap_add(ocelot, port, l2_cookie,
                               ocelot_populate_l2_ptp_trap_key);
@@ -1545,15 +1545,15 @@ static int ocelot_l2_ptp_trap_add(struct ocelot *ocelot, int port)
 
 static int ocelot_l2_ptp_trap_del(struct ocelot *ocelot, int port)
 {
-       unsigned long l2_cookie = ocelot->num_phys_ports + 1;
+       unsigned long l2_cookie = OCELOT_VCAP_IS2_L2_PTP_TRAP(ocelot);
 
        return ocelot_trap_del(ocelot, port, l2_cookie);
 }
 
 static int ocelot_ipv4_ptp_trap_add(struct ocelot *ocelot, int port)
 {
-       unsigned long ipv4_gen_cookie = ocelot->num_phys_ports + 2;
-       unsigned long ipv4_ev_cookie = ocelot->num_phys_ports + 3;
+       unsigned long ipv4_gen_cookie = OCELOT_VCAP_IS2_IPV4_GEN_PTP_TRAP(ocelot);
+       unsigned long ipv4_ev_cookie = OCELOT_VCAP_IS2_IPV4_EV_PTP_TRAP(ocelot);
        int err;
 
        err = ocelot_trap_add(ocelot, port, ipv4_ev_cookie,
@@ -1571,8 +1571,8 @@ static int ocelot_ipv4_ptp_trap_add(struct ocelot *ocelot, int port)
 
 static int ocelot_ipv4_ptp_trap_del(struct ocelot *ocelot, int port)
 {
-       unsigned long ipv4_gen_cookie = ocelot->num_phys_ports + 2;
-       unsigned long ipv4_ev_cookie = ocelot->num_phys_ports + 3;
+       unsigned long ipv4_gen_cookie = OCELOT_VCAP_IS2_IPV4_GEN_PTP_TRAP(ocelot);
+       unsigned long ipv4_ev_cookie = OCELOT_VCAP_IS2_IPV4_EV_PTP_TRAP(ocelot);
        int err;
 
        err = ocelot_trap_del(ocelot, port, ipv4_ev_cookie);
@@ -1582,8 +1582,8 @@ static int ocelot_ipv4_ptp_trap_del(struct ocelot *ocelot, int port)
 
 static int ocelot_ipv6_ptp_trap_add(struct ocelot *ocelot, int port)
 {
-       unsigned long ipv6_gen_cookie = ocelot->num_phys_ports + 4;
-       unsigned long ipv6_ev_cookie = ocelot->num_phys_ports + 5;
+       unsigned long ipv6_gen_cookie = OCELOT_VCAP_IS2_IPV6_GEN_PTP_TRAP(ocelot);
+       unsigned long ipv6_ev_cookie = OCELOT_VCAP_IS2_IPV6_EV_PTP_TRAP(ocelot);
        int err;
 
        err = ocelot_trap_add(ocelot, port, ipv6_ev_cookie,
@@ -1601,8 +1601,8 @@ static int ocelot_ipv6_ptp_trap_add(struct ocelot *ocelot, int port)
 
 static int ocelot_ipv6_ptp_trap_del(struct ocelot *ocelot, int port)
 {
-       unsigned long ipv6_gen_cookie = ocelot->num_phys_ports + 4;
-       unsigned long ipv6_ev_cookie = ocelot->num_phys_ports + 5;
+       unsigned long ipv6_gen_cookie = OCELOT_VCAP_IS2_IPV6_GEN_PTP_TRAP(ocelot);
+       unsigned long ipv6_ev_cookie = OCELOT_VCAP_IS2_IPV6_EV_PTP_TRAP(ocelot);
        int err;
 
        err = ocelot_trap_del(ocelot, port, ipv6_ev_cookie);

diff --git a/drivers/net/ethernet/mscc/ocelot_mrp.c b/drivers/net/ethernet/mscc/ocelot_mrp.c
index 742242bab6efbe176a40025f0916c054c94c5b74..d763fb32a56c3982497a472f0c094dd2c97eba54 100644 (file)
--- a/drivers/net/ethernet/mscc/ocelot_mrp.c
+++ b/drivers/net/ethernet/mscc/ocelot_mrp.c
@@ -60,7 +60,7 @@ static int ocelot_mrp_redirect_add_vcap(struct ocelot *ocelot, int src_port,
 
        filter->key_type = OCELOT_VCAP_KEY_ETYPE;
        filter->prio = 1;
-       filter->id.cookie = src_port;
+       filter->id.cookie = OCELOT_VCAP_IS2_MRP_REDIRECT(ocelot, src_port);
        filter->id.tc_offload = false;
        filter->block_id = VCAP_IS2;
        filter->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -77,8 +77,7 @@ static int ocelot_mrp_redirect_add_vcap(struct ocelot *ocelot, int src_port,
        return err;
 }
 
-static int ocelot_mrp_copy_add_vcap(struct ocelot *ocelot, int port,
-                                   int prio, unsigned long cookie)
+static int ocelot_mrp_copy_add_vcap(struct ocelot *ocelot, int port, int prio)
 {
        const u8 mrp_mask[] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0x00 };
        struct ocelot_vcap_filter *filter;
@@ -90,7 +89,7 @@ static int ocelot_mrp_copy_add_vcap(struct ocelot *ocelot, int port,
 
        filter->key_type = OCELOT_VCAP_KEY_ETYPE;
        filter->prio = prio;
-       filter->id.cookie = cookie;
+       filter->id.cookie = OCELOT_VCAP_IS2_MRP_TRAP(ocelot, port);
        filter->id.tc_offload = false;
        filter->block_id = VCAP_IS2;
        filter->type = OCELOT_VCAP_FILTER_OFFLOAD;
@@ -186,8 +185,7 @@ int ocelot_mrp_add_ring_role(struct ocelot *ocelot, int port,
        ocelot_mrp_save_mac(ocelot, ocelot_port);
 
        if (mrp->ring_role != BR_MRP_RING_ROLE_MRC)
-               return ocelot_mrp_copy_add_vcap(ocelot, port, 1,
-                                               port + ocelot->num_phys_ports);
+               return ocelot_mrp_copy_add_vcap(ocelot, port, 1);
 
        dst_port = ocelot_mrp_find_partner_port(ocelot, ocelot_port);
        if (dst_port == -1)
@@ -197,10 +195,10 @@ int ocelot_mrp_add_ring_role(struct ocelot *ocelot, int port,
        if (err)
                return err;
 
-       err = ocelot_mrp_copy_add_vcap(ocelot, port, 2,
-                                      port + ocelot->num_phys_ports);
+       err = ocelot_mrp_copy_add_vcap(ocelot, port, 2);
        if (err) {
-               ocelot_mrp_del_vcap(ocelot, port);
+               ocelot_mrp_del_vcap(ocelot,
+                                   OCELOT_VCAP_IS2_MRP_REDIRECT(ocelot, port));
                return err;
        }
 
@@ -223,8 +221,8 @@ int ocelot_mrp_del_ring_role(struct ocelot *ocelot, int port,
        if (ocelot_port->mrp_ring_id != mrp->ring_id)
                return 0;
 
-       ocelot_mrp_del_vcap(ocelot, port);
-       ocelot_mrp_del_vcap(ocelot, port + ocelot->num_phys_ports);
+       ocelot_mrp_del_vcap(ocelot, OCELOT_VCAP_IS2_MRP_REDIRECT(ocelot, port));
+       ocelot_mrp_del_vcap(ocelot, OCELOT_VCAP_IS2_MRP_TRAP(ocelot, port));
 
        for (i = 0; i < ocelot->num_phys_ports; ++i) {
                ocelot_port = ocelot->ports[i];

diff --git a/include/soc/mscc/ocelot_vcap.h b/include/soc/mscc/ocelot_vcap.h
index 709cbc198fd20c6cd2c45c477db18c961bf63085..562bcd9721323324375b9e6a2662b79767183f9f 100644 (file)
--- a/include/soc/mscc/ocelot_vcap.h
+++ b/include/soc/mscc/ocelot_vcap.h
@@ -8,6 +8,22 @@
 
 #include <soc/mscc/ocelot.h>
 
+/* Cookie definitions for private VCAP filters installed by the driver.
+ * Must be unique per VCAP block.
+ */
+#define OCELOT_VCAP_ES0_TAG_8021Q_RXVLAN(ocelot, port)         (port)
+#define OCELOT_VCAP_IS1_TAG_8021Q_TXVLAN(ocelot, port)         (port)
+#define OCELOT_VCAP_IS1_TAG_8021Q_PTP_MMIO(ocelot)             ((ocelot)->num_phys_ports)
+#define OCELOT_VCAP_IS2_TAG_8021Q_TXVLAN(ocelot, port)         (port)
+#define OCELOT_VCAP_IS2_TAG_8021Q_PTP_MMIO(ocelot)             ((ocelot)->num_phys_ports)
+#define OCELOT_VCAP_IS2_L2_PTP_TRAP(ocelot)                    ((ocelot)->num_phys_ports + 1)
+#define OCELOT_VCAP_IS2_IPV4_GEN_PTP_TRAP(ocelot)              ((ocelot)->num_phys_ports + 2)
+#define OCELOT_VCAP_IS2_IPV4_EV_PTP_TRAP(ocelot)               ((ocelot)->num_phys_ports + 3)
+#define OCELOT_VCAP_IS2_IPV6_GEN_PTP_TRAP(ocelot)              ((ocelot)->num_phys_ports + 4)
+#define OCELOT_VCAP_IS2_IPV6_EV_PTP_TRAP(ocelot)               ((ocelot)->num_phys_ports + 5)
+#define OCELOT_VCAP_IS2_MRP_REDIRECT(ocelot, port)             (port)
+#define OCELOT_VCAP_IS2_MRP_TRAP(ocelot, port)                 ((ocelot)->num_phys_ports + (port))
+
 /* =================================================================
  *  VCAP Common
  * =================================================================