net: usb: ax88179_178a: restore state on resume

The hardware state was only partially restored, which meant certain
functionality was broken on resume. Do a full HW reset on resume to
fix this.

Signed-off-by: Justin Chen <justinpopo6@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c
index c641fd4970d1e1dd115b3ec23dbc8f24da375461..1cc388a385b2b2f4592c12ba357aabd753743a7f 100644 (file)
--- a/drivers/net/usb/ax88179_178a.c
+++ b/drivers/net/usb/ax88179_178a.c
@@ -465,37 +465,12 @@ static int ax88179_auto_detach(struct usbnet *dev)
 static int ax88179_resume(struct usb_interface *intf)
 {
        struct usbnet *dev = usb_get_intfdata(intf);
-       u16 tmp16;
-       u8 tmp8;
 
        ax88179_set_pm_mode(dev, true);
 
        usbnet_link_change(dev, 0, 0);
 
-       /* Power up ethernet PHY */
-       tmp16 = 0;
-       ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL,
-                         2, 2, &tmp16);
-       udelay(1000);
-
-       tmp16 = AX_PHYPWR_RSTCTL_IPRL;
-       ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_PHYPWR_RSTCTL,
-                         2, 2, &tmp16);
-       msleep(200);
-
-       /* Ethernet PHY Auto Detach*/
-       ax88179_auto_detach(dev);
-
-       /* Enable clock */
-       ax88179_read_cmd(dev, AX_ACCESS_MAC,  AX_CLK_SELECT, 1, 1, &tmp8);
-       tmp8 |= AX_CLK_SELECT_ACS | AX_CLK_SELECT_BCS;
-       ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_CLK_SELECT, 1, 1, &tmp8);
-       msleep(100);
-
-       /* Configure RX control register => start operation */
-       tmp16 = AX_RX_CTL_DROPCRCERR | AX_RX_CTL_IPE | AX_RX_CTL_START |
-               AX_RX_CTL_AP | AX_RX_CTL_AMALL | AX_RX_CTL_AB;
-       ax88179_write_cmd(dev, AX_ACCESS_MAC, AX_RX_CTL, 2, 2, &tmp16);
+       ax88179_reset(dev);
 
        ax88179_set_pm_mode(dev, false);