]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/st7571-i2c: correct pixel data format description
authorMarcus Folkesson <marcus.folkesson@gmail.com>
Mon, 21 Jul 2025 10:43:31 +0000 (12:43 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Mon, 1 Sep 2025 13:26:43 +0000 (15:26 +0200)
The comment describes the pixel data format as stated in
the st7571 datasheet, which is not necessary the same
as for the connected display.

Instead, describe the expected pixel data format which is used for
R1/R2/XRGB8888.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Link: https://lore.kernel.org/r/20250721-st7571-format-v2-1-159f4134098c@gmail.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/sitronix/st7571-i2c.c

index dda99cbe5372b0f8feb4f14826bd1ecdaa20782a..6f814294342855f0b9b4dea9c9625281422f75d8 100644 (file)
@@ -386,10 +386,10 @@ static int st7571_fb_update_rect_grayscale(struct drm_framebuffer *fb, struct dr
                         * even if the format is monochrome.
                         *
                         * The bit values maps to the following grayscale:
-                        * 0 0 = White
-                        * 0 1 = Light gray
-                        * 1 0 = Dark gray
-                        * 1 1 = Black
+                        * 0 0 = Black
+                        * 0 1 = Dark gray
+                        * 1 0 = Light gray
+                        * 1 1 = White
                         *
                         * For monochrome formats, write the same value twice to get
                         * either a black or white pixel.