]> www.infradead.org Git - users/dwmw2/pidgin-headset.git/commitdiff
Fix use-after-free on killing media streams
authorDavid Woodhouse <dwmw2@infradead.org>
Thu, 19 Apr 2018 17:12:10 +0000 (18:12 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Thu, 19 Apr 2018 17:12:10 +0000 (18:12 +0100)
headset.c

index 000c1f1f2736cc4bab755c78c7dc5d92b14d4ac4..903d7b6e5eca57472b3dc399de91471d61b2c1f2 100644 (file)
--- a/headset.c
+++ b/headset.c
@@ -61,8 +61,9 @@ static gboolean foreach_media(media_cb fn, gpointer user_data)
        GList *medias = purple_media_manager_get_media(mgr);
        gboolean ret = FALSE;
 
-       for (; medias; medias = medias->next) {
+       while (medias) {
                PurpleMedia *media = medias->data;
+               medias = medias->next;
 
                GList *sess_ids = purple_media_get_session_ids(media);
                while (sess_ids) {