bpf: Fix bpf_dynptr_slice{_rdwr} to return NULL instead of 0

Change bpf_dynptr_slice and bpf_dynptr_slice_rdwr to return NULL instead
of 0, in accordance with the codebase guidelines.

Fixes: 66e3a13e7c2c ("bpf: Add bpf_dynptr_slice and bpf_dynptr_slice_rdwr")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20230302053014.1726219-1-joannelkoong@gmail.com

diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c
index 58431a92bb65e81124605f88e42c52d5e61927bb..de9ef8476e2984d582a81bb2dac44b9bd518473a 100644 (file)
--- a/kernel/bpf/helpers.c
+++ b/kernel/bpf/helpers.c
@@ -2227,11 +2227,11 @@ __bpf_kfunc void *bpf_dynptr_slice(const struct bpf_dynptr_kern *ptr, u32 offset
        int err;
 
        if (!ptr->data)
-               return 0;
+               return NULL;
 
        err = bpf_dynptr_check_off_len(ptr, offset, len);
        if (err)
-               return 0;
+               return NULL;
 
        type = bpf_dynptr_get_type(ptr);
 
@@ -2252,7 +2252,7 @@ __bpf_kfunc void *bpf_dynptr_slice(const struct bpf_dynptr_kern *ptr, u32 offset
        }
        default:
                WARN_ONCE(true, "unknown dynptr type %d\n", type);
-               return 0;
+               return NULL;
        }
 }
 
@@ -2300,7 +2300,7 @@ __bpf_kfunc void *bpf_dynptr_slice_rdwr(const struct bpf_dynptr_kern *ptr, u32 o
                                        void *buffer, u32 buffer__szk)
 {
        if (!ptr->data || bpf_dynptr_is_rdonly(ptr))
-               return 0;
+               return NULL;
 
        /* bpf_dynptr_slice_rdwr is the same logic as bpf_dynptr_slice.
         *