]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
btrfs: make btrfs_finish_ordered_extent() return void
authorFilipe Manana <fdmanana@suse.com>
Wed, 15 May 2024 12:54:14 +0000 (13:54 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 11 Jul 2024 13:33:18 +0000 (15:33 +0200)
Currently btrfs_finish_ordered_extent() returns a boolean indicating if
the ordered extent was added to the work queue for completion, but none
of its callers cares about it, so make it return void.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ordered-data.c
fs/btrfs/ordered-data.h

index 7d175d10a6d0c35393dc8098433a4f22cf6fcf47..16f9ddd2831cf6eca241adbc52824c72fdfec7ea 100644 (file)
@@ -374,7 +374,7 @@ static void btrfs_queue_ordered_fn(struct btrfs_ordered_extent *ordered)
        btrfs_queue_work(wq, &ordered->work);
 }
 
-bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
+void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
                                 struct page *page, u64 file_offset, u64 len,
                                 bool uptodate)
 {
@@ -421,7 +421,6 @@ bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
 
        if (ret)
                btrfs_queue_ordered_fn(ordered);
-       return ret;
 }
 
 /*
index b6f6c6b91732d59f9012f6fd4e072e0c1dd73cc5..bef22179e7c5e94ac11bcdefdc3c296ef9588fcb 100644 (file)
@@ -162,7 +162,7 @@ int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent);
 void btrfs_put_ordered_extent(struct btrfs_ordered_extent *entry);
 void btrfs_remove_ordered_extent(struct btrfs_inode *btrfs_inode,
                                struct btrfs_ordered_extent *entry);
-bool btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
+void btrfs_finish_ordered_extent(struct btrfs_ordered_extent *ordered,
                                 struct page *page, u64 file_offset, u64 len,
                                 bool uptodate);
 void btrfs_mark_ordered_io_finished(struct btrfs_inode *inode,