]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: phy: micrel: use %pe in print format
authorJakub Kicinski <kuba@kernel.org>
Thu, 18 Sep 2025 18:31:19 +0000 (11:31 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 20 Sep 2025 00:01:57 +0000 (17:01 -0700)
New cocci check complains:

  drivers/net/phy/micrel.c:4308:6-13: WARNING: Consider using %pe to print PTR_ERR()
  drivers/net/phy/micrel.c:5742:6-13: WARNING: Consider using %pe to print PTR_ERR()

Link: https://lore.kernel.org/1758192227-701925-1-git-send-email-tariqt@nvidia.com
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250918183119.2396019-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/micrel.c

index af05764394f69f201c3295b0c3acf2e5f3efeef0..399d0cf4d3426da57137ec790b9ef3cf946f1952 100644 (file)
@@ -4304,8 +4304,8 @@ static int __lan8814_ptp_probe_once(struct phy_device *phydev, char *pin_name,
        shared->ptp_clock = ptp_clock_register(&shared->ptp_clock_info,
                                               &phydev->mdio.dev);
        if (IS_ERR(shared->ptp_clock)) {
-               phydev_err(phydev, "ptp_clock_register failed %lu\n",
-                          PTR_ERR(shared->ptp_clock));
+               phydev_err(phydev, "ptp_clock_register failed %pe\n",
+                          shared->ptp_clock);
                return -EINVAL;
        }
 
@@ -5738,8 +5738,8 @@ static int lan8841_probe(struct phy_device *phydev)
        ptp_priv->ptp_clock = ptp_clock_register(&ptp_priv->ptp_clock_info,
                                                 &phydev->mdio.dev);
        if (IS_ERR(ptp_priv->ptp_clock)) {
-               phydev_err(phydev, "ptp_clock_register failed: %lu\n",
-                          PTR_ERR(ptp_priv->ptp_clock));
+               phydev_err(phydev, "ptp_clock_register failed: %pe\n",
+                          ptp_priv->ptp_clock);
                return -EINVAL;
        }