]> www.infradead.org Git - users/hch/misc.git/commitdiff
bnxt_en: add .set_module_eeprom_by_page() support
authorDamodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Mon, 10 Mar 2025 18:31:29 +0000 (11:31 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 09:25:22 +0000 (10:25 +0100)
Add support for .set_module_eeprom_by_page() callback
which implements generic solution for modules eeprom access.
This implementation also supports CMIS 5.0.3 compliant
eeprom FW download.

Sample Usage:
ethtool --flash-module-firmware enp177s0np0 file dummy.bin

Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250310183129.3154117-8-michael.chan@broadcom.com
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c

index c0de8f0e722d3f7e12c9564581945f21ed99bb8e..48dd5922e4dd8bd322e19bdab29c7d27120119e4 100644 (file)
@@ -4550,7 +4550,7 @@ bnxt_mod_eeprom_by_page_precheck(struct bnxt *bp,
 
        if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) {
                NL_SET_ERR_MSG_MOD(extack,
-                                  "Module read not permitted on untrusted VF");
+                                  "Module read/write not permitted on untrusted VF");
                return -EPERM;
        }
 
@@ -4593,6 +4593,62 @@ static int bnxt_get_module_eeprom_by_page(struct net_device *dev,
        return page_data->length;
 }
 
+static int bnxt_write_sfp_module_eeprom_info(struct bnxt *bp,
+                                            const struct ethtool_module_eeprom *page)
+{
+       struct hwrm_port_phy_i2c_write_input *req;
+       int bytes_written = 0;
+       int rc;
+
+       rc = hwrm_req_init(bp, req, HWRM_PORT_PHY_I2C_WRITE);
+       if (rc)
+               return rc;
+
+       hwrm_req_hold(bp, req);
+       req->i2c_slave_addr = page->i2c_address << 1;
+       req->page_number = cpu_to_le16(page->page);
+       req->bank_number = page->bank;
+       req->port_id = cpu_to_le16(bp->pf.port_id);
+       req->enables = cpu_to_le32(PORT_PHY_I2C_WRITE_REQ_ENABLES_PAGE_OFFSET |
+                                  PORT_PHY_I2C_WRITE_REQ_ENABLES_BANK_NUMBER);
+
+       while (bytes_written < page->length) {
+               u16 xfer_size;
+
+               xfer_size = min_t(u16, page->length - bytes_written,
+                                 BNXT_MAX_PHY_I2C_RESP_SIZE);
+               req->page_offset = cpu_to_le16(page->offset + bytes_written);
+               req->data_length = xfer_size;
+               memcpy(req->data, page->data + bytes_written, xfer_size);
+               rc = hwrm_req_send(bp, req);
+               if (rc)
+                       break;
+               bytes_written += xfer_size;
+       }
+
+       hwrm_req_drop(bp, req);
+       return rc;
+}
+
+static int bnxt_set_module_eeprom_by_page(struct net_device *dev,
+                                         const struct ethtool_module_eeprom *page_data,
+                                         struct netlink_ext_ack *extack)
+{
+       struct bnxt *bp = netdev_priv(dev);
+       int rc;
+
+       rc = bnxt_mod_eeprom_by_page_precheck(bp, page_data, extack);
+       if (rc)
+               return rc;
+
+       rc = bnxt_write_sfp_module_eeprom_info(bp, page_data);
+       if (rc) {
+               NL_SET_ERR_MSG_MOD(extack, "Module`s eeprom write failed");
+               return rc;
+       }
+       return page_data->length;
+}
+
 static int bnxt_nway_reset(struct net_device *dev)
 {
        int rc = 0;
@@ -5455,6 +5511,7 @@ const struct ethtool_ops bnxt_ethtool_ops = {
        .get_module_info        = bnxt_get_module_info,
        .get_module_eeprom      = bnxt_get_module_eeprom,
        .get_module_eeprom_by_page = bnxt_get_module_eeprom_by_page,
+       .set_module_eeprom_by_page = bnxt_set_module_eeprom_by_page,
        .nway_reset             = bnxt_nway_reset,
        .set_phys_id            = bnxt_set_phys_id,
        .self_test              = bnxt_self_test,