]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
misc: sram: constify 'struct bin_attribute'
authorThomas Weißschuh <linux@weissschuh.net>
Sat, 21 Dec 2024 14:48:09 +0000 (15:48 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Dec 2024 08:36:02 +0000 (09:36 +0100)
The sysfs core now allows instances of 'struct bin_attribute' to be
moved into read-only memory. Make use of that to protect them against
accidental or malicious modifications.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241221-sysfs-const-bin_attr-misc-drivers-v2-3-ba5e79fe8771@weissschuh.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/sram.c

index e40b027a88e25209933a20dc9dbd7db29cb81ba5..e5069882457ef6ba5dc084d02994034dc39d24c6 100644 (file)
@@ -23,7 +23,7 @@
 #define SRAM_GRANULARITY       32
 
 static ssize_t sram_read(struct file *filp, struct kobject *kobj,
-                        struct bin_attribute *attr,
+                        const struct bin_attribute *attr,
                         char *buf, loff_t pos, size_t count)
 {
        struct sram_partition *part;
@@ -38,7 +38,7 @@ static ssize_t sram_read(struct file *filp, struct kobject *kobj,
 }
 
 static ssize_t sram_write(struct file *filp, struct kobject *kobj,
-                         struct bin_attribute *attr,
+                         const struct bin_attribute *attr,
                          char *buf, loff_t pos, size_t count)
 {
        struct sram_partition *part;
@@ -83,8 +83,8 @@ static int sram_add_export(struct sram_dev *sram, struct sram_reserve *block,
                return -ENOMEM;
 
        part->battr.attr.mode = S_IRUSR | S_IWUSR;
-       part->battr.read = sram_read;
-       part->battr.write = sram_write;
+       part->battr.read_new = sram_read;
+       part->battr.write_new = sram_write;
        part->battr.size = block->size;
 
        return device_create_bin_file(sram->dev, &part->battr);