drm/i915: Split plane watermark parameters into a separate struct

Give a name to the plane watermark related data we have currently
stored under intel_plane->wm.

We also observe that this data is more or less the same that we have
in the hsw_pipe_wm_parameters structure, so use it there as well.

v2: Make pahole happier

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 7df662bab280c8f046ac65e7ff1b44f64089f0b0..3ea8e5fe44071fcb7056feb96fbcd6e734fa32ac 100644 (file)
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -331,6 +331,13 @@ struct intel_crtc {
        bool pch_fifo_underrun_disabled;
 };
 
+struct intel_plane_wm_parameters {
+       uint32_t horiz_pixels;
+       uint8_t bytes_per_pixel;
+       bool enabled;
+       bool scaled;
+};
+
 struct intel_plane {
        struct drm_plane base;
        int plane;
@@ -349,12 +356,7 @@ struct intel_plane {
         * as the other pieces of the struct may not reflect the values we want
         * for the watermark calculations. Currently only Haswell uses this.
         */
-       struct {
-               bool enabled;
-               bool scaled;
-               uint8_t bytes_per_pixel;
-               uint32_t horiz_pixels;
-       } wm;
+       struct intel_plane_wm_parameters wm;
 
        void (*update_plane)(struct drm_plane *plane,
                             struct drm_framebuffer *fb,

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 550f787a3b4a20f31ad6f3acc111aebeed39f5e2..ed772fecbb079bd81a93929e6f16608ea3a932b1 100644 (file)
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -2162,15 +2162,11 @@ static uint32_t ilk_wm_fbc(uint32_t pri_val, uint32_t horiz_pixels,
 
 struct hsw_pipe_wm_parameters {
        bool active;
-       bool sprite_enabled;
-       uint8_t pri_bytes_per_pixel;
-       uint8_t spr_bytes_per_pixel;
-       uint8_t cur_bytes_per_pixel;
-       uint32_t pri_horiz_pixels;
-       uint32_t spr_horiz_pixels;
-       uint32_t cur_horiz_pixels;
        uint32_t pipe_htotal;
        uint32_t pixel_rate;
+       struct intel_plane_wm_parameters pri;
+       struct intel_plane_wm_parameters spr;
+       struct intel_plane_wm_parameters cur;
 };
 
 struct hsw_wm_maximums {
@@ -2206,12 +2202,11 @@ static uint32_t ilk_compute_pri_wm(struct hsw_pipe_wm_parameters *params,
 {
        uint32_t method1, method2;
 
-       /* TODO: for now, assume the primary plane is always enabled. */
-       if (!params->active)
+       if (!params->active || !params->pri.enabled)
                return 0;
 
        method1 = ilk_wm_method1(params->pixel_rate,
-                                params->pri_bytes_per_pixel,
+                                params->pri.bytes_per_pixel,
                                 mem_value);
 
        if (!is_lp)
@@ -2219,8 +2214,8 @@ static uint32_t ilk_compute_pri_wm(struct hsw_pipe_wm_parameters *params,
 
        method2 = ilk_wm_method2(params->pixel_rate,
                                 params->pipe_htotal,
-                                params->pri_horiz_pixels,
-                                params->pri_bytes_per_pixel,
+                                params->pri.horiz_pixels,
+                                params->pri.bytes_per_pixel,
                                 mem_value);
 
        return min(method1, method2);
@@ -2235,16 +2230,16 @@ static uint32_t ilk_compute_spr_wm(struct hsw_pipe_wm_parameters *params,
 {
        uint32_t method1, method2;
 
-       if (!params->active || !params->sprite_enabled)
+       if (!params->active || !params->spr.enabled)
                return 0;
 
        method1 = ilk_wm_method1(params->pixel_rate,
-                                params->spr_bytes_per_pixel,
+                                params->spr.bytes_per_pixel,
                                 mem_value);
        method2 = ilk_wm_method2(params->pixel_rate,
                                 params->pipe_htotal,
-                                params->spr_horiz_pixels,
-                                params->spr_bytes_per_pixel,
+                                params->spr.horiz_pixels,
+                                params->spr.bytes_per_pixel,
                                 mem_value);
        return min(method1, method2);
 }
@@ -2256,13 +2251,13 @@ static uint32_t ilk_compute_spr_wm(struct hsw_pipe_wm_parameters *params,
 static uint32_t ilk_compute_cur_wm(struct hsw_pipe_wm_parameters *params,
                                   uint32_t mem_value)
 {
-       if (!params->active)
+       if (!params->active || !params->cur.enabled)
                return 0;
 
        return ilk_wm_method2(params->pixel_rate,
                              params->pipe_htotal,
-                             params->cur_horiz_pixels,
-                             params->cur_bytes_per_pixel,
+                             params->cur.horiz_pixels,
+                             params->cur.bytes_per_pixel,
                              mem_value);
 }
 
@@ -2270,12 +2265,12 @@ static uint32_t ilk_compute_cur_wm(struct hsw_pipe_wm_parameters *params,
 static uint32_t ilk_compute_fbc_wm(struct hsw_pipe_wm_parameters *params,
                                   uint32_t pri_val)
 {
-       if (!params->active)
+       if (!params->active || !params->pri.enabled)
                return 0;
 
        return ilk_wm_fbc(pri_val,
-                         params->pri_horiz_pixels,
-                         params->pri_bytes_per_pixel);
+                         params->pri.horiz_pixels,
+                         params->pri.bytes_per_pixel);
 }
 
 static unsigned int ilk_display_fifo_size(const struct drm_device *dev)
@@ -2636,11 +2631,14 @@ static void hsw_compute_wm_parameters(struct drm_device *dev,
 
                p->pipe_htotal = intel_crtc->config.adjusted_mode.htotal;
                p->pixel_rate = ilk_pipe_pixel_rate(dev, crtc);
-               p->pri_bytes_per_pixel = crtc->fb->bits_per_pixel / 8;
-               p->cur_bytes_per_pixel = 4;
-               p->pri_horiz_pixels =
+               p->pri.bytes_per_pixel = crtc->fb->bits_per_pixel / 8;
+               p->cur.bytes_per_pixel = 4;
+               p->pri.horiz_pixels =
                        intel_crtc->config.requested_mode.hdisplay;
-               p->cur_horiz_pixels = 64;
+               p->cur.horiz_pixels = 64;
+               /* TODO: for now, assume primary and cursor planes are always enabled. */
+               p->pri.enabled = true;
+               p->cur.enabled = true;
        }
 
        list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
@@ -2650,11 +2648,10 @@ static void hsw_compute_wm_parameters(struct drm_device *dev,
                pipe = intel_plane->pipe;
                p = &params[pipe];
 
-               p->sprite_enabled = intel_plane->wm.enabled;
-               p->spr_bytes_per_pixel = intel_plane->wm.bytes_per_pixel;
-               p->spr_horiz_pixels = intel_plane->wm.horiz_pixels;
+               p->spr = intel_plane->wm;
 
-               config.sprites_enabled |= p->sprite_enabled;
+               config.sprites_enabled |= p->spr.enabled;
+               config.sprites_scaled |= p->spr.scaled;
        }
 
        ilk_wm_max(dev, 1, &config, INTEL_DDB_PART_1_2, lp_max_1_2);