]> www.infradead.org Git - users/hch/misc.git/commitdiff
rxrpc: rxperf: Fix missing decoding of terminal magic cookie
authorDavid Howells <dhowells@redhat.com>
Tue, 18 Feb 2025 19:22:44 +0000 (19:22 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 21 Feb 2025 23:06:29 +0000 (15:06 -0800)
The rxperf RPCs seem to have a magic cookie at the end of the request that
was failing to be taken account of by the unmarshalling of the request.
Fix the rxperf code to expect this.

Fixes: 75bfdbf2fca3 ("rxrpc: Implement an in-kernel rxperf server for testing purposes")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: Simon Horman <horms@kernel.org>
cc: linux-afs@lists.infradead.org
Link: https://patch.msgid.link/20250218192250.296870-2-dhowells@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rxrpc/rxperf.c

index 7ef93407be8306b97c27cc4effeaf088eeb3303c..e848a4777b8c7d9ac56f07a35ce87df3641a8cdc 100644 (file)
@@ -478,6 +478,18 @@ static int rxperf_deliver_request(struct rxperf_call *call)
                call->unmarshal++;
                fallthrough;
        case 2:
+               ret = rxperf_extract_data(call, true);
+               if (ret < 0)
+                       return ret;
+
+               /* Deal with the terminal magic cookie. */
+               call->iov_len = 4;
+               call->kvec[0].iov_len   = call->iov_len;
+               call->kvec[0].iov_base  = call->tmp;
+               iov_iter_kvec(&call->iter, READ, call->kvec, 1, call->iov_len);
+               call->unmarshal++;
+               fallthrough;
+       case 3:
                ret = rxperf_extract_data(call, false);
                if (ret < 0)
                        return ret;