]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: i2c: imx283: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:02 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:21 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx283.c

index da618c8cbadc3bff9165c6e50ef66aaa29bf5104..8bff5bf4df12a4231f40da986727bbc630dfc631 100644 (file)
@@ -1462,11 +1462,10 @@ static int imx283_probe(struct i2c_client *client)
        }
 
        /* Get system clock (xclk) */
-       imx283->xclk = devm_clk_get(imx283->dev, NULL);
-       if (IS_ERR(imx283->xclk)) {
+       imx283->xclk = devm_v4l2_sensor_clk_get(imx283->dev, NULL);
+       if (IS_ERR(imx283->xclk))
                return dev_err_probe(imx283->dev, PTR_ERR(imx283->xclk),
                                     "failed to get xclk\n");
-       }
 
        xclk_freq = clk_get_rate(imx283->xclk);
        for (i = 0; i < ARRAY_SIZE(imx283_frequencies); i++) {