]> www.infradead.org Git - linux.git/commitdiff
spi: atmel-quadspi: Fix uninitialized res
authorJinjie Ruan <ruanjinjie@huawei.com>
Mon, 26 Aug 2024 12:59:12 +0000 (20:59 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 28 Aug 2024 21:11:16 +0000 (22:11 +0100)
The second platform_get_resource_byname() can not be replaced with
devm_platform_ioremap_resource_byname(), because the intermediate "res"
is used to assign for "aq->mmap_size".

Fixes: 3ccea1dedef3 ("spi: atmel-quadspi: Simpify resource lookup")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Acked-by: Hari Prasath Gujulan Elango <hari.prasathge@microchip.com>
Link: https://patch.msgid.link/20240826125913.3434305-2-ruanjinjie@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/atmel-quadspi.c

index 2b5c72176711c2f4db46d24ea4eabffc4b43ce9d..56dd8dcb86cbe0d2cc92864bbd7b5c00099682a5 100644 (file)
@@ -608,7 +608,8 @@ static int atmel_qspi_probe(struct platform_device *pdev)
        }
 
        /* Map the AHB memory */
-       aq->mem = devm_platform_ioremap_resource_byname(pdev, "qspi_mmap");
+       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qspi_mmap");
+       aq->mem = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(aq->mem)) {
                dev_err(&pdev->dev, "missing AHB memory\n");
                return PTR_ERR(aq->mem);