Variable r is being assigned a value that is never read. The assignment is
redundant and so is the variable, so remove these. Remove unnecessary the
{} braces in the if statement too.
Link: https://lore.kernel.org/r/20211205225901.54362-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
 
 static int
 mpt_host_page_access_control(MPT_ADAPTER *ioc, u8 access_control_value, int sleepFlag)
 {
-       int      r = 0;
-
        /* return if in use */
        if (CHIPREG_READ32(&ioc->chip->Doorbell)
            & MPI_DOORBELL_ACTIVE)
                 (access_control_value<<12)));
 
        /* Wait for IOC to clear Doorbell Status bit */
-       if ((r = WaitForDoorbellAck(ioc, 5, sleepFlag)) < 0) {
+       if (WaitForDoorbellAck(ioc, 5, sleepFlag) < 0)
                return -2;
-       }else
+       else
                return 0;
 }