]> www.infradead.org Git - linux.git/commitdiff
arm64: dts: exynos5433: add specific compatibles to several blocks
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 8 Nov 2023 10:43:39 +0000 (11:43 +0100)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 15 Nov 2023 11:50:39 +0000 (12:50 +0100)
Exynos5433 reuses several devices from older designs, thus historically
we kept the old (block's) compatible only.  This works fine and there is
no bug here, however guidelines expressed in
Documentation/devicetree/bindings/writing-bindings.rst state that:
1. Compatibles should be specific.
2. We should add new compatibles in case of bugs or features.

Add compatibles specific to Exynos5433 in front of all old-SoC-like
compatibles.  This will also help reviews of new code using existing
DTS as template.  No functional impact on Linux drivers behavior.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Link: https://lore.kernel.org/r/20231108104343.24192-14-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
arch/arm64/boot/dts/exynos/exynos5433.dtsi

index 91ae0462a706a6c104b83a021c123445b4388ef8..7fbbec04bff037a6f36757397f6bea4504cc385f 100644 (file)
                ranges = <0x0 0x0 0x0 0x18000000>;
 
                chipid@10000000 {
-                       compatible = "samsung,exynos4210-chipid";
+                       compatible = "samsung,exynos5433-chipid",
+                                    "samsung,exynos4210-chipid";
                        reg = <0x10000000 0x100>;
                };
 
                        reg = <0x10580000 0x1a20>, <0x11090000 0x100>;
 
                        wakeup-interrupt-controller {
-                               compatible = "samsung,exynos7-wakeup-eint";
+                               compatible = "samsung,exynos5433-wakeup-eint",
+                                            "samsung,exynos7-wakeup-eint";
                                interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
                        };
                };
                };
 
                adc: adc@14d10000 {
-                       compatible = "samsung,exynos7-adc";
+                       compatible = "samsung,exynos5433-adc", "samsung,exynos7-adc";
                        reg = <0x14d10000 0x100>;
                        interrupts = <GIC_SPI 438 IRQ_TYPE_LEVEL_HIGH>;
                        clock-names = "adc";
                };
 
                i2s1: i2s@14d60000 {
-                       compatible = "samsung,exynos7-i2s";
+                       compatible = "samsung,exynos5433-i2s", "samsung,exynos7-i2s";
                        reg = <0x14d60000 0x100>;
                        dmas = <&pdma0 31>, <&pdma0 30>;
                        dma-names = "tx", "rx";
                };
 
                pwm: pwm@14dd0000 {
-                       compatible = "samsung,exynos4210-pwm";
+                       compatible = "samsung,exynos5433-pwm", "samsung,exynos4210-pwm";
                        reg = <0x14dd0000 0x100>;
                        interrupts = <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH>,
                                     <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>,
                };
 
                hsi2c_0: i2c@14e40000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14e40000 0x1000>;
                        interrupts = <GIC_SPI 428 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_1: i2c@14e50000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14e50000 0x1000>;
                        interrupts = <GIC_SPI 429 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_2: i2c@14e60000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14e60000 0x1000>;
                        interrupts = <GIC_SPI 430 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_3: i2c@14e70000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14e70000 0x1000>;
                        interrupts = <GIC_SPI 431 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_4: i2c@14ec0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14ec0000 0x1000>;
                        interrupts = <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_5: i2c@14ed0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14ed0000 0x1000>;
                        interrupts = <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_6: i2c@14ee0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14ee0000 0x1000>;
                        interrupts = <GIC_SPI 426 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_7: i2c@14ef0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14ef0000 0x1000>;
                        interrupts = <GIC_SPI 427 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_8: i2c@14d90000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14d90000 0x1000>;
                        interrupts = <GIC_SPI 443 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_9: i2c@14da0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14da0000 0x1000>;
                        interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_10: i2c@14de0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14de0000 0x1000>;
                        interrupts = <GIC_SPI 445 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                hsi2c_11: i2c@14df0000 {
-                       compatible = "samsung,exynos7-hsi2c";
+                       compatible = "samsung,exynos5433-hsi2c",
+                                    "samsung,exynos7-hsi2c";
                        reg = <0x14df0000 0x1000>;
                        interrupts = <GIC_SPI 446 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                };
 
                mshc_0: mmc@15540000 {
-                       compatible = "samsung,exynos7-dw-mshc-smu";
+                       compatible = "samsung,exynos5433-dw-mshc-smu",
+                                    "samsung,exynos7-dw-mshc-smu";
                        interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                        #size-cells = <0>;
                };
 
                mshc_1: mmc@15550000 {
-                       compatible = "samsung,exynos7-dw-mshc-smu";
+                       compatible = "samsung,exynos5433-dw-mshc-smu",
+                                    "samsung,exynos7-dw-mshc-smu";
                        interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                        #size-cells = <0>;
                };
 
                mshc_2: mmc@15560000 {
-                       compatible = "samsung,exynos7-dw-mshc-smu";
+                       compatible = "samsung,exynos5433-dw-mshc-smu",
+                                    "samsung,exynos7-dw-mshc-smu";
                        interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
                        #address-cells = <1>;
                        #size-cells = <0>;
                        };
 
                        i2s0: i2s@11440000 {
-                               compatible = "samsung,exynos7-i2s";
+                               compatible = "samsung,exynos5433-i2s",
+                                            "samsung,exynos7-i2s";
                                reg = <0x11440000 0x100>;
                                dmas = <&adma 0>, <&adma 2>;
                                dma-names = "tx", "rx";