staging: rtl8723bs: Fix compilation errors for W=1 build

When building a kernel with Clang 19 the couple of warnings
become the errors (due to CONFIG_WERROR=y by default).

.../rtl8723bs/core/rtw_xmit.c:1939:13: error: variable 'drop_cnt' set but not used [-Werror,-Wunused-but-set-variable]
.../rtl8723bs/hal/hal_com.c:893:6: error: variable 'res' set but not used [-Werror,-Wunused-but-set-variable]

Fix them accordingly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250415091019.545905-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 297c93d6531571d7989b4545f9cada8f09e002b3..e2f7b24155242d0ba243efda403b373586cef91d 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -1936,7 +1936,6 @@ static void do_queue_select(struct adapter        *padapter, struct pkt_attrib *pattrib
 s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt)
 {
        static unsigned long start;
-       static u32 drop_cnt;
 
        struct xmit_priv *pxmitpriv = &padapter->xmitpriv;
        struct xmit_frame *pxmitframe = NULL;
@@ -1948,15 +1947,11 @@ s32 rtw_xmit(struct adapter *padapter, struct sk_buff **ppkt)
 
        pxmitframe = rtw_alloc_xmitframe(pxmitpriv);
 
-       if (jiffies_to_msecs(jiffies - start) > 2000) {
+       if (jiffies_to_msecs(jiffies - start) > 2000)
                start = jiffies;
-               drop_cnt = 0;
-       }
 
-       if (!pxmitframe) {
-               drop_cnt++;
+       if (!pxmitframe)
                return -1;
-       }
 
        res = update_attrib(padapter, *ppkt, &pxmitframe->attrib);
 

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 1213a91cffffbd280b38f36e5af3b8365beb7c0f..d91e2461fd7e4e8f8405d5865c0b1157753a9e87 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -890,15 +890,14 @@ static u32 Array_kfreemap[] = {
 void rtw_bb_rf_gain_offset(struct adapter *padapter)
 {
        u8 value = padapter->eeprompriv.EEPROMRFGainOffset;
-       u32 res, i = 0;
        u32 *Array = Array_kfreemap;
        u32 v1 = 0, v2 = 0, target = 0;
+       u32 i = 0;
 
        if (value & BIT4) {
                if (padapter->eeprompriv.EEPROMRFGainVal != 0xff) {
-                       res = rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff);
-                       res &= 0xfff87fff;
-                       /* res &= 0xfff87fff; */
+                       rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff);
+
                        for (i = 0; i < ARRAY_SIZE(Array_kfreemap); i += 2) {
                                v1 = Array[i];
                                v2 = Array[i+1];
@@ -909,9 +908,7 @@ void rtw_bb_rf_gain_offset(struct adapter *padapter)
                        }
                        PHY_SetRFReg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, BIT18|BIT17|BIT16|BIT15, target);
 
-                       /* res |= (padapter->eeprompriv.EEPROMRFGainVal & 0x0f)<< 15; */
-                       /* rtw_hal_write_rfreg(padapter, RF_PATH_A, REG_RF_BB_GAIN_OFFSET, RF_GAIN_OFFSET_MASK, res); */
-                       res = rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff);
+                       rtw_hal_read_rfreg(padapter, RF_PATH_A, 0x7f, 0xffffffff);
                }
        }
 }