]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Fix potential leak of cookie_buf on error path
authorDavid Woodhouse <dwmw2@infradead.org>
Thu, 28 Apr 2022 18:44:39 +0000 (19:44 +0100)
committerDavid Woodhouse <dwmw2@infradead.org>
Thu, 28 Apr 2022 18:44:51 +0000 (19:44 +0100)
Spotted by Coverity.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
auth.c

diff --git a/auth.c b/auth.c
index dc4e7ddb2f2f55bea74c4c3cb17ec3ebec77f07c..c02b87a29764c1b2a8eeadb2e5a3b350e477b32c 100644 (file)
--- a/auth.c
+++ b/auth.c
@@ -1685,6 +1685,7 @@ newgroup:
 
                        if (bu && fu && sha) {
                                if (asprintf(&vpninfo->profile_url, "%s%s", bu, fu) == -1) {
+                                       buf_free(cookie_buf);
                                        result = -ENOMEM;
                                        goto out;
                                }