]> www.infradead.org Git - users/hch/xfstests-dev.git/commitdiff
common/rc: use _try_scratch_mount for scratch_remount
authorXiaoli Feng <xifeng@redhat.com>
Tue, 9 Apr 2019 02:48:33 +0000 (10:48 +0800)
committerEryu Guan <guaneryu@gmail.com>
Tue, 9 Apr 2019 03:34:30 +0000 (11:34 +0800)
When call _scratch_remount for cifs , it always requires to input
password. This will make generic/306 generic/452 failed because
cifs remount failed.

Signed-off-by: Xiaoli Feng <xifeng@redhat.com>
Reviewed-and-tested-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
common/rc
tests/overlay/035

index 1fb6af4cc80c4f595d91ddb6647fd57831770520..92ef9c7d0392dea927a48e416fbb85dac44d7836 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -357,7 +357,7 @@ _scratch_remount()
     local opts="$1"
 
     if test -n "$opts"; then
-       mount -o "remount,$opts" $SCRATCH_MNT
+       _try_scratch_mount "-o remount,$opts"
     fi
 }
 
index f36c1e10cc705f7781520c77fca82f1b50f9434c..c0aae935bcf17dea20e1fa9c5e5cee80e05c812d 100755 (executable)
@@ -55,7 +55,7 @@ mkdir -p $lowerdir1 $lowerdir2 $upperdir $workdir
 $MOUNT_PROG -t overlay -o"lowerdir=$lowerdir2:$lowerdir1" \
                        $OVL_BASE_SCRATCH_MNT $SCRATCH_MNT
 touch $SCRATCH_MNT/foo 2>&1 | _filter_scratch
-_scratch_remount rw 2>&1 | _filter_ro_mount
+$MOUNT_PROG -o remount,rw $SCRATCH_MNT 2>&1 | _filter_ro_mount
 $UMOUNT_PROG $SCRATCH_MNT
 
 # Make workdir immutable to prevent workdir re-create on mount