Add one new file vga-pci.h and cleanup on all platforms

Functions pci_vga_init() and pci_cirrus_vga_init() are declared
in pc.h. That prevents other platforms (e.g. sPAPR) to use them.

This patch is to create one new file vga-pci.h and move the
declarations to vga-pci.h, so that they can be shared by
all platforms. This patch also cleans up on all platforms.

Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
Signed-off-by: Alexander Graf <agraf@suse.de>

diff --git a/hw/alpha_pci.c b/hw/alpha_pci.c
index 673557781e60ec3f597dea030527163c8800dc4c..ea546f83f18045a4539ea283fa18f0db20807a4c 100644 (file)
--- a/hw/alpha_pci.c
+++ b/hw/alpha_pci.c
@@ -11,6 +11,7 @@
 #include "qemu-log.h"
 #include "sysemu.h"
 #include "vmware_vga.h"
+#include "vga-pci.h"
 
 
 /* PCI IO reads/writes, to byte-word addressable memory.  */

diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c
index 623dd688d9071d3e83172f7707fd34da36c7ad18..e8dcc6b883a22350d6e9fa03b732f38617d16029 100644 (file)
--- a/hw/cirrus_vga.c
+++ b/hw/cirrus_vga.c
@@ -27,8 +27,8 @@
  *   available at http://home.worldonline.dk/~finth/
  */
 #include "hw.h"
-#include "pc.h"
 #include "pci.h"
+#include "vga-pci.h"
 #include "console.h"
 #include "vga_int.h"
 #include "loader.h"

diff --git a/hw/mips_malta.c b/hw/mips_malta.c
index 351c88ebca3153d3e3ef6a636651bb0ce76e34ef..ad23f26e597f9ff886d72c173ee5b0caefbb2871 100644 (file)
--- a/hw/mips_malta.c
+++ b/hw/mips_malta.c
@@ -48,6 +48,7 @@
 #include "blockdev.h"
 #include "exec-memory.h"
 #include "sysbus.h"             /* SysBusDevice */
+#include "vga-pci.h"
 
 //#define DEBUG_BOARD_INIT
 

diff --git a/hw/pc.c b/hw/pc.c
index e8bcfc0b4b1f758e7015be3674f6d79c8380a3c4..3ed1a3caa2e5e827b506b110b7504acef6865257 100644 (file)
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -51,6 +51,7 @@
 #include "exec-memory.h"
 #include "arch_init.h"
 #include "bitmap.h"
+#include "vga-pci.h"
 
 /* output Bochs bios info messages */
 //#define DEBUG_BIOS

diff --git a/hw/pc.h b/hw/pc.h
index 31ccb6f49527ae955fc2f831b394d2fe61ed436f..e4db0715b81e8248d0f1cf76179b4f9afa4d8dd8 100644 (file)
--- a/hw/pc.h
+++ b/hw/pc.h
@@ -189,14 +189,10 @@ static inline DeviceState *isa_vga_init(ISABus *bus)
     return &dev->qdev;
 }
 
-DeviceState *pci_vga_init(PCIBus *bus);
 int isa_vga_mm_init(target_phys_addr_t vram_base,
                     target_phys_addr_t ctrl_base, int it_shift,
                     MemoryRegion *address_space);
 
-/* cirrus_vga.c */
-DeviceState *pci_cirrus_vga_init(PCIBus *bus);
-
 /* ne2000.c */
 static inline bool isa_ne2000_init(ISABus *bus, int base, int irq, NICInfo *nd)
 {

diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c
index 4e2a6e691b3a8705ce3ea015506a9c0af57d8676..e95cfe831e262da68685595e9a01edbb8b9e9c07 100644 (file)
--- a/hw/ppc_newworld.c
+++ b/hw/ppc_newworld.c
@@ -52,7 +52,6 @@
 #include "adb.h"
 #include "mac_dbdma.h"
 #include "nvram.h"
-#include "pc.h"
 #include "pci.h"
 #include "net.h"
 #include "sysemu.h"
@@ -68,6 +67,7 @@
 #include "hw/usb.h"
 #include "blockdev.h"
 #include "exec-memory.h"
+#include "vga-pci.h"
 
 #define MAX_IDE_BUS 2
 #define CFG_ADDR 0xf0000510

diff --git a/hw/ppc_oldworld.c b/hw/ppc_oldworld.c
index f2c6908534e8c741585215ea1fd3bf9479de736b..1dcd8a6c36d303277a7af4a0234c95dfcc7b959e 100644 (file)
--- a/hw/ppc_oldworld.c
+++ b/hw/ppc_oldworld.c
@@ -29,7 +29,6 @@
 #include "adb.h"
 #include "mac_dbdma.h"
 #include "nvram.h"
-#include "pc.h"
 #include "sysemu.h"
 #include "net.h"
 #include "isa.h"
@@ -44,6 +43,7 @@
 #include "kvm_ppc.h"
 #include "blockdev.h"
 #include "exec-memory.h"
+#include "vga-pci.h"
 
 #define MAX_IDE_BUS 2
 #define CFG_ADDR 0xf0000510

diff --git a/hw/ppc_prep.c b/hw/ppc_prep.c
index be2b26830deed1f728c01aa8f0582b63540919a8..7a876164c9b9cd82f26ad0467d3f48b04c357480 100644 (file)
--- a/hw/ppc_prep.c
+++ b/hw/ppc_prep.c
@@ -39,6 +39,7 @@
 #include "blockdev.h"
 #include "arch_init.h"
 #include "exec-memory.h"
+#include "vga-pci.h"
 
 //#define HARD_DEBUG_PPC_IO
 //#define DEBUG_PPC_IO

diff --git a/hw/sun4u.c b/hw/sun4u.c
index 137a7c6666d671bbca44d22b1f220adca0f4e4cb..07cd04273a81da10444800adfc803576b4f280f7 100644 (file)
--- a/hw/sun4u.c
+++ b/hw/sun4u.c
@@ -39,6 +39,7 @@
 #include "elf.h"
 #include "blockdev.h"
 #include "exec-memory.h"
+#include "vga-pci.h"
 
 //#define DEBUG_IRQ
 //#define DEBUG_EBUS

diff --git a/hw/vga-pci.c b/hw/vga-pci.c
index 37dc019a61fee9ce9c2b204524efb17f87a7a685..9abbada8f17a8737814c1de48e6c16e3cd95c514 100644 (file)
--- a/hw/vga-pci.c
+++ b/hw/vga-pci.c
@@ -23,8 +23,8 @@
  */
 #include "hw.h"
 #include "console.h"
-#include "pc.h"
 #include "pci.h"
+#include "vga-pci.h"
 #include "vga_int.h"
 #include "pixel_ops.h"
 #include "qemu-timer.h"

diff --git a/hw/vga-pci.h b/hw/vga-pci.h
new file mode 100644 (file)
index 0000000..49abf13
--- /dev/null
+++ b/hw/vga-pci.h
@@ -0,0 +1,12 @@
+#ifndef VGA_PCI_H
+#define VGA_PCI_H
+
+#include "qemu-common.h"
+
+/* vga-pci.c */
+DeviceState *pci_vga_init(PCIBus *bus);
+
+/* cirrus_vga.c */
+DeviceState *pci_cirrus_vga_init(PCIBus *bus);
+
+#endif