]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: imu: inv_icm42600: fix spi burst write not supported
authorJean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Tue, 12 Nov 2024 09:30:10 +0000 (10:30 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:22:54 +0000 (17:22 +0000)
Burst write with SPI is not working for all icm42600 chips. It was
only used for setting user offsets with regmap_bulk_write.

Add specific SPI regmap config for using only single write with SPI.

Fixes: 9f9ff91b775b ("iio: imu: inv_icm42600: add SPI driver for inv_icm42600 driver")
Cc: stable@vger.kernel.org
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Link: https://patch.msgid.link/20241112-inv-icm42600-fix-spi-burst-write-not-supported-v2-1-97690dc03607@tdk.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_icm42600/inv_icm42600.h
drivers/iio/imu/inv_icm42600/inv_icm42600_core.c
drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c

index 3a07e43e4cf154f3107c015c30248330d8e677f8..18787a43477b89db12caee597ab040af5c8f52d5 100644 (file)
@@ -403,6 +403,7 @@ struct inv_icm42600_sensor_state {
 typedef int (*inv_icm42600_bus_setup)(struct inv_icm42600_state *);
 
 extern const struct regmap_config inv_icm42600_regmap_config;
+extern const struct regmap_config inv_icm42600_spi_regmap_config;
 extern const struct dev_pm_ops inv_icm42600_pm_ops;
 
 const struct iio_mount_matrix *
index 561d245c1d6446251934aa8529caaf6f00710017..e43538e536f0abe63a38acab58bd0338c37ac35a 100644 (file)
@@ -87,6 +87,21 @@ const struct regmap_config inv_icm42600_regmap_config = {
 };
 EXPORT_SYMBOL_NS_GPL(inv_icm42600_regmap_config, "IIO_ICM42600");
 
+/* define specific regmap for SPI not supporting burst write */
+const struct regmap_config inv_icm42600_spi_regmap_config = {
+       .name = "inv_icm42600",
+       .reg_bits = 8,
+       .val_bits = 8,
+       .max_register = 0x4FFF,
+       .ranges = inv_icm42600_regmap_ranges,
+       .num_ranges = ARRAY_SIZE(inv_icm42600_regmap_ranges),
+       .volatile_table = inv_icm42600_regmap_volatile_accesses,
+       .rd_noinc_table = inv_icm42600_regmap_rd_noinc_accesses,
+       .cache_type = REGCACHE_RBTREE,
+       .use_single_write = true,
+};
+EXPORT_SYMBOL_NS_GPL(inv_icm42600_spi_regmap_config, "IIO_ICM42600");
+
 struct inv_icm42600_hw {
        uint8_t whoami;
        const char *name;
index c55d8e672183dd79a0912e6a7ccde4b6ad054dd2..2bd2c4c8e50c3fe081e882aca6c64736510b474c 100644 (file)
@@ -59,7 +59,8 @@ static int inv_icm42600_probe(struct spi_device *spi)
                return -EINVAL;
        chip = (uintptr_t)match;
 
-       regmap = devm_regmap_init_spi(spi, &inv_icm42600_regmap_config);
+       /* use SPI specific regmap */
+       regmap = devm_regmap_init_spi(spi, &inv_icm42600_spi_regmap_config);
        if (IS_ERR(regmap))
                return PTR_ERR(regmap);