]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: pci: mg4b: fix uninitialized iio scan data
authorDavid Lechner <dlechner@baylibre.com>
Tue, 22 Jul 2025 22:05:46 +0000 (17:05 -0500)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 29 Aug 2025 09:04:02 +0000 (11:04 +0200)
Fix potential leak of uninitialized stack data to userspace by ensuring
that the `scan` structure is zeroed before use.

Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver")
Cc: stable@vger.kernel.org
Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/pci/mgb4/mgb4_trigger.c

index 923650d53d4c82e87b542f87c3a0fbf6170dadc8..d7dddc5c8728e81c6249b03a4cbf692da15a4ced 100644 (file)
@@ -91,7 +91,7 @@ static irqreturn_t trigger_handler(int irq, void *p)
        struct {
                u32 data;
                s64 ts __aligned(8);
-       } scan;
+       } scan = { };
 
        scan.data = mgb4_read_reg(&st->mgbdev->video, 0xA0);
        mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data);