]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drm/nouveau: create pci device once
authorBen Skeggs <bskeggs@nvidia.com>
Fri, 26 Jul 2024 04:37:55 +0000 (14:37 +1000)
committerDanilo Krummrich <dakr@kernel.org>
Sat, 27 Jul 2024 01:05:20 +0000 (03:05 +0200)
HW isn't touched anymore (aside from detection) until the first
nvif_device has been allocated, so we no longer need a separate
probe-only step before kicking efifb (etc) off the HW.

Signed-off-by: Ben Skeggs <bskeggs@nvidia.com>
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240726043828.58966-5-bskeggs@nvidia.com
drivers/gpu/drm/nouveau/nouveau_drm.c

index 0687bc59d486f7e70117f37fc709c3e22cfb461f..f372bf2954aa3fe26a47725321ae6e0e900af421 100644 (file)
@@ -839,23 +839,16 @@ static int nouveau_drm_probe(struct pci_dev *pdev,
        /* We need to check that the chipset is supported before booting
         * fbdev off the hardware, as there's no way to put it back.
         */
-       ret = nvkm_device_pci_new(pdev, nouveau_config, "error",
-                                 true, false, 0, &device);
+       ret = nvkm_device_pci_new(pdev, nouveau_config, nouveau_debug,
+                                 true, true, ~0ULL, &device);
        if (ret)
                return ret;
 
-       nvkm_device_del(&device);
-
        /* Remove conflicting drivers (vesafb, efifb etc). */
        ret = drm_aperture_remove_conflicting_pci_framebuffers(pdev, &driver_pci);
        if (ret)
                return ret;
 
-       ret = nvkm_device_pci_new(pdev, nouveau_config, nouveau_debug,
-                                 true, true, ~0ULL, &device);
-       if (ret)
-               return ret;
-
        pci_set_master(pdev);
 
        if (nouveau_atomic)